You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2015/06/09 06:23:01 UTC
ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in
ZipArchiveEntry#getMergedFields
Repository: ant
Updated Branches:
refs/heads/master e9d4c9ae8 -> 6e34f177e
COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields
Too bad this hasn't been found two weeks before.
Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/6e34f177
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/6e34f177
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/6e34f177
Branch: refs/heads/master
Commit: 6e34f177ee9e41ba3d066b6a4c92b21dbdf28804
Parents: e9d4c9a
Author: Stefan Bodewig <bo...@apache.org>
Authored: Tue Jun 9 06:22:27 2015 +0200
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Tue Jun 9 06:22:27 2015 +0200
----------------------------------------------------------------------
CONTRIBUTORS | 1 +
WHATSNEW | 4 ++++
contributors.xml | 4 ++++
src/main/org/apache/tools/zip/ZipEntry.java | 2 +-
4 files changed, 10 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ant/blob/6e34f177/CONTRIBUTORS
----------------------------------------------------------------------
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 0a0d0fb..e78bd62 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -214,6 +214,7 @@ Larry Streepy
Les Hughes
Levi Cook
lucas
+Lucas Werkmeister
Ludovic Claude
Maarten Coene
Magesh Umasankar
http://git-wip-us.apache.org/repos/asf/ant/blob/6e34f177/WHATSNEW
----------------------------------------------------------------------
diff --git a/WHATSNEW b/WHATSNEW
index 0cacc73..6db5548 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -7,6 +7,10 @@ Changes that could break older environments:
Fixed bugs:
-----------
+ * ArrayIndexOutOfBoundsException when ZIP extra fields are read and
+ the entry contains an UnparseableExtraField.
+ https://issues.apache.org/jira/browse/COMPRESS-317
+
Other changes:
--------------
http://git-wip-us.apache.org/repos/asf/ant/blob/6e34f177/contributors.xml
----------------------------------------------------------------------
diff --git a/contributors.xml b/contributors.xml
index d7c7162..7ea115e 100644
--- a/contributors.xml
+++ b/contributors.xml
@@ -883,6 +883,10 @@
<last>lucas</last>
</name>
<name>
+ <first>Lucas</first>
+ <last>Werkmeister</last>
+ </name>
+ <name>
<first>Ludovic</first>
<last>Claude</last>
</name>
http://git-wip-us.apache.org/repos/asf/ant/blob/6e34f177/src/main/org/apache/tools/zip/ZipEntry.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/zip/ZipEntry.java b/src/main/org/apache/tools/zip/ZipEntry.java
index f66baf2..30a8155 100644
--- a/src/main/org/apache/tools/zip/ZipEntry.java
+++ b/src/main/org/apache/tools/zip/ZipEntry.java
@@ -361,7 +361,7 @@ public class ZipEntry extends java.util.zip.ZipEntry implements Cloneable {
private ZipExtraField[] getMergedFields() {
final ZipExtraField[] zipExtraFields =
copyOf(extraFields, extraFields.length + 1);
- zipExtraFields[zipExtraFields.length] = unparseableExtra;
+ zipExtraFields[extraFields.length] = unparseableExtra;
return zipExtraFields;
}
AW: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Same for me.
Can't judge over the extra field.
But we should keep 3-part version numbers.
Jan
> -----Ursprüngliche Nachricht-----
> Von: Nicolas Lalevée [mailto:nicolas.lalevee@hibnet.org]
> Gesendet: Mittwoch, 10. Juni 2015 18:55
> An: Ant Developers List
> Betreff: Re: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-
> 317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
>
> I don’t much about popularity of these extra fields, but the bug seems
> annoying enough and the fix trivial enough to release an Ant 1.9.6 (I
> don’t see the need to add an extra number to the version).
> So +1.
>
> Nicolas
>
> > Le 9 juin 2015 à 06:34, Stefan Bodewig <bo...@apache.org> a écrit :
> >
> > On 2015-06-09, <bo...@apache.org> wrote:
> >
> >> COMPRESS-317 ArrayIndexOutOfBoundsException in
> >> ZipArchiveEntry#getMergedFields
> >
> >> Too bad this hasn't been found two weeks before.
> >
> >> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/6e34f177
> >
> > Whenever the extr fields of a ZIP entry are read that contains an
> > extra field we cannot parse because it doesn't follow the
> > recommendation by the spec we'll throw. The extra fields are read
> > internally when copying entries from one archive to another or when
> > looking for UnicodeExtraFields.
> >
> > To me this sounds serious enough to warrant a new release, that I'm
> > willing to act as RM for.
> >
> > Cheers
> >
> > Stefan
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> > commands, e-mail: dev-help@ant.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-06-18, Jan Matèrne (jhm) wrote:
> Actually my time is over and I'll have to do some other work.
> So I can't invest more at the moment.
> So, Stefan, you could start a release. ;)
Thanks. Not sure when I'll find time, may take until the end of June.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Actually my time is over and I'll have to do some other work.
So I can't invest more at the moment.
So, Stefan, you could start a release. ;)
Jan
> -----Ursprüngliche Nachricht-----
> Von: Jan Matèrne (jhm) [mailto:apache@materne.de]
> Gesendet: Freitag, 12. Juni 2015 13:53
> An: 'Ant Developers List'
> Betreff: AW: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-
> 317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
>
> > Jan, I see you are fixing a few things, should I give you some time
> to
> > finish your selected bugs?
>
>
> Yes, thanks.
> I'll ping you if I have finished.
> Most of the work is closing old issues.
> Some require more attention ...
>
> Jan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
> Jan, I see you are fixing a few things, should I give you some time to
> finish your selected bugs?
Yes, thanks.
I'll ping you if I have finished.
Most of the work is closing old issues.
Some require more attention ...
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-06-10, Nicolas Lalevée wrote:
> I don’t much about popularity of these extra fields, but the bug seems
> annoying enough and the fix trivial enough to release an Ant 1.9.6 (I
> don’t see the need to add an extra number to the version).
1.9.6 is fine with me.
Jan, I see you are fixing a few things, should I give you some time to
finish your selected bugs?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by Nicolas Lalevée <ni...@hibnet.org>.
I don’t much about popularity of these extra fields, but the bug seems annoying enough and the fix trivial enough to release an Ant 1.9.6 (I don’t see the need to add an extra number to the version).
So +1.
Nicolas
> Le 9 juin 2015 à 06:34, Stefan Bodewig <bo...@apache.org> a écrit :
>
> On 2015-06-09, <bo...@apache.org> wrote:
>
>> COMPRESS-317 ArrayIndexOutOfBoundsException in
>> ZipArchiveEntry#getMergedFields
>
>> Too bad this hasn't been found two weeks before.
>
>> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/6e34f177
>
> Whenever the extr fields of a ZIP entry are read that contains an extra
> field we cannot parse because it doesn't follow the recommendation by
> the spec we'll throw. The extra fields are read internally when copying
> entries from one archive to another or when looking for
> UnicodeExtraFields.
>
> To me this sounds serious enough to warrant a new release, that I'm
> willing to act as RM for.
>
> Cheers
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Doing a quick 1.9.5.1? (was Re: ant git commit: COMPRESS-317 ArrayIndexOutOfBoundsException in ZipArchiveEntry#getMergedFields)
Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-06-09, <bo...@apache.org> wrote:
> COMPRESS-317 ArrayIndexOutOfBoundsException in
> ZipArchiveEntry#getMergedFields
> Too bad this hasn't been found two weeks before.
> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/6e34f177
Whenever the extr fields of a ZIP entry are read that contains an extra
field we cannot parse because it doesn't follow the recommendation by
the spec we'll throw. The extra fields are read internally when copying
entries from one archive to another or when looking for
UnicodeExtraFields.
To me this sounds serious enough to warrant a new release, that I'm
willing to act as RM for.
Cheers
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org