You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/13 13:49:05 UTC
[GitHub] [iotdb] Beyyes opened a new pull request, #7591: [IOTDB-4623] Enhance the stability of remove-confignode.sh when executed in non-running node
Beyyes opened a new pull request, #7591:
URL: https://github.com/apache/iotdb/pull/7591
Description
see more details in https://issues.apache.org/jira/browse/IOTDB-4623
mainly do this improvement, remove-confignode.sh rpc transfer to leader confignode id firstly
image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #7591: [IOTDB-4623] Enhance the stability of remove-confignode.sh when executed in non-running node
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #7591:
URL: https://github.com/apache/iotdb/pull/7591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a diff in pull request #7591: [IOTDB-4623] Enhance the stability of remove-confignode.sh when executed in non-running node
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #7591:
URL: https://github.com/apache/iotdb/pull/7591#discussion_r995270772
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeRemoveCheck.java:
##########
@@ -103,10 +110,15 @@ public void removeConfigNode(TConfigNodeLocation removedNode)
if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
break;
}
+
+ if (status.getCode() == TSStatusCode.REMOVE_CONFIGNODE_FAILED.getStatusCode()) {
+ break;
Review Comment:
print a log in failed situation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7591: [IOTDB-4623] Enhance the stability of remove-confignode.sh when executed in non-running node
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7591:
URL: https://github.com/apache/iotdb/pull/7591#discussion_r995303596
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeRemoveCheck.java:
##########
@@ -103,10 +110,15 @@ public void removeConfigNode(TConfigNodeLocation removedNode)
if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
break;
}
+
+ if (status.getCode() == TSStatusCode.REMOVE_CONFIGNODE_FAILED.getStatusCode()) {
+ break;
Review Comment:
i will fix it in next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org