You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/11/18 07:47:56 UTC
[GitHub] [incubator-brpc] changchengx opened a new pull request, #2003: src/butil: correct assign atomic pointer member to be NULL
changchengx opened a new pull request, #2003:
URL: https://github.com/apache/incubator-brpc/pull/2003
1. memset assign value to var without considering var type.
2. memset can't guarantee atomic operation
Signed-off-by: Liu, Changcheng <ch...@aliyun.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] changchengx commented on pull request #2003: src/butil: correct assign atomic pointer member to be NULL
Posted by GitBox <gi...@apache.org>.
changchengx commented on PR #2003:
URL: https://github.com/apache/incubator-brpc/pull/2003#issuecomment-1319715850
@wwbmmm No. From semantic perspective, memset doesn't consider variable type at all and guarantee atomic operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #2003: src/butil: correct assign atomic pointer member to be NULL
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on PR #2003:
URL: https://github.com/apache/incubator-brpc/pull/2003#issuecomment-1319702633
@changchengx Do you have any problem using memset ? (eg. compile error or unexpected behavior at runtime)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #2003: src/butil: correct assign atomic pointer member to be NULL
Posted by GitBox <gi...@apache.org>.
serverglen commented on PR #2003:
URL: https://github.com/apache/incubator-brpc/pull/2003#issuecomment-1321408977
Could you please submit the application scenario of brpc in your company?
See #1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org