You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by Chetan Mehrotra <ch...@gmail.com> on 2013/07/23 14:05:37 UTC

Re: svn commit: r1505988 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/ oak-core/src/main/java/org/...

Should the synchronization be done on "this" or some other object
which is common across branch instances as there can be multiple
instances of the branch

On Tue, Jul 23, 2013 at 5:15 PM,  <md...@apache.org> wrote:
> +        synchronized (this) {
> +            rebase();
> +            NodeState toCommit = checkNotNull(hook).processCommit(base, head);
> +            NodeState oldRoot = head;
> +            head = toCommit;



Chetan Mehrotra

Re: svn commit: r1505988 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/ oak-core/src/main/java/org/...

Posted by Michael Dürig <md...@apache.org>.


On 23.7.13 14:05, Chetan Mehrotra wrote:
> Should the synchronization be done on "this" or some other object
> which is common across branch instances

Good catch! I introduced an explicit merge lock at 
http://svn.apache.org/r1506027

Michael