You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/07/04 19:03:11 UTC
[jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Make examples more consistent.
https://issues.apache.org/jira/browse/JCLOUDS-170
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-examples rax-examples-updates
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-examples/pull/10
-- Commit Summary --
* Remove deprecated methods from Rackspace examples. Make examples more consistent.
-- File Changes --
M rackspace/src/main/java/org/jclouds/examples/rackspace/Authentication.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/Logging.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/CreateSnapshot.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/CreateVolumeAndAttach.java (10)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DeleteSnapshot.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DeleteVolume.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DetachVolume.java (10)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListSnapshots.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumeAttachments.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumeTypes.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumes.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CRUDReverseDNSRecords.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CreateDomains.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CreateRecords.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/DeleteDomains.java (16)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/DeleteRecords.java (16)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/ListDomains.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/ListRecords.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/UpdateDomains.java (14)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/UpdateRecords.java (16)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CloudFilesPublish.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CreateContainer.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CrossOriginResourceSharingContainer.java (3)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/DeleteObjectsAndContainer.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/GenerateTempURL.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/ListContainers.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/ListObjects.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/UploadLargeObject.java (5)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/UploadObjects.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/AddNodes.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/CreateLoadBalancerWithExistingServers.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/CreateLoadBalancerWithNewServers.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/DeleteLoadBalancers.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/ListLoadBalancers.java (17)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/RemoveNodes.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/UpdateLoadBalancers.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/UpdateNodes.java (18)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudservers/CloudServersPublish.java (5)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudservers/CreateServer.java (6)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudservers/DeleteServer.java (8)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudservers/ListServersWithFiltering.java (9)
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudservers/ServerMetadata.java (15)
-- Patch Links --
https://github.com/jclouds/jclouds-examples/pull/10.patch
https://github.com/jclouds/jclouds-examples/pull/10.diff
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Everett Toews <no...@github.com>.
Examples run 100% successfully.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10#issuecomment-20489154
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Andrew Phillips <no...@github.com>.
> */
> public void close() {
> - closeQuietly(dnsApi);
> + if (dnsApi != null) {
> + try {
> + dnsApi.close();
> + }
> + catch (Exception e) {
> + e.printStackTrace();
> + }
Why catching exceptions around _this_ `.close()` and not in the other examples? Is there something specific to CloudDNSApi going on here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10/files#r5134210
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Andrew Phillips <no...@github.com>.
> @@ -108,6 +109,8 @@ private void authenticateOnCall() {
> * Always close your service when you're done with it.
> */
> public void close() {
> - closeQuietly(compute.getContext());
> + if (compute != null) {
> + compute.getContext();
Missing `.close()` here? (see also below a couple of times)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10/files#r5134195
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Everett Toews <no...@github.com>.
Closed #10.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Andrew Phillips <no...@github.com>.
> @@ -65,6 +63,9 @@ public static void main(String[] args) {
> authentication.init(args);
> authentication.authenticateOnCall();
> }
> + catch (Exception e) {
> + e.printStackTrace();
> + }
What do these blocks add? Would the exception not be printed when the program exits?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10/files#r5134194
Re: [jclouds-examples] JCLOUDS-170: Remove deprecated methods from
Rackspace examples. (#10)
Posted by Everett Toews <no...@github.com>.
Merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/10#issuecomment-20490045