[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1190: [CELEBORN-244][IMPROVEMENT] Separate outstandingPushes from outstandingRpcs

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1190:
URL: https://github.com/apache/incubator-celeborn/pull/1190#discussion_r1092693000


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -321,4 +321,21 @@ protected void handleFailure(String errorMsg, Throwable cause) {
       callback.onFailure(new IOException(errorMsg, cause));
     }
   }
+
+  private class PushChannelListener extends StdChannelListener {
+    final long rpcRequestId;
+    final RpcResponseCallback callback;
+
+    PushChannelListener(long rpcRequestId, RpcResponseCallback callback) {

Review Comment:
   DO ne



##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -168,12 +190,22 @@ public void handle(ResponseMessage message) throws Exception {
       RpcResponse resp = (RpcResponse) message;
       RpcResponseCallback listener = outstandingRpcs.get(resp.requestId);
       if (listener == null) {
-        logger.warn(
-            "Ignoring response for RPC {} from {} ({} bytes) since it is not outstanding",
-            resp.requestId,
-            NettyUtils.getRemoteAddress(channel),
-            resp.body().size());
-        resp.body().release();
+        listener = outstandingPushs.get(resp.requestId);

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org