You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/03/09 15:27:07 UTC
[GitHub] [tomcat] pavandv9 opened a new pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
pavandv9 opened a new pull request #481:
URL: https://github.com/apache/tomcat/pull/481
currently deployment order is not maintain, in order to overcome this we can change HashMap to LinkedHashMap.
So that the deployment order in <context> maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] pavandv9 commented on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
pavandv9 commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063832888
I agree to your point, but again since web applications are independent many applications may be running in order.
So I hope by doing this it doesn't affect the existing feature and it will add more advantage to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] pavandv9 commented on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
pavandv9 commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063696340
Can someone review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] pavandv9 removed a comment on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
pavandv9 removed a comment on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063696340
Can someone review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1082229465
No response to Chris's questions so closing this as WONTFIX. Maintaining deployment order of applications is something probably best discussed on the users list in the first instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063793228
That is a backwards incompatible change so, if made, it will only be made to the 10.1.x branch.
Web applications are meant to be independent. If there are dependencies between two or more web applications then those applications should be coded so that they correctly handle starting in different orders.
Generally, the Tomcat project does not implement features that enforce this sort of ordering as it undermines portability.
I am close to -1 on this proposal but will leave the PR open for others to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1065380953
What exactly does this accomplish? LinkedHashMap just produces iterators which maintain insertion-order. It doesn't impose any order on when they were inserted.
Is this intended to maintain _redeployment_-order when auto-deployment is enabled and all applications are updated simultaneously? If so, it's entirely possible that your application updates would be processed across multiple background-processing executions and therefore wouldn't necessarily be redeployed in the order you expected, anyway.
I must not understand the use-case, here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #481: changing HashMap to LinkedHashMap to maintain execution order of deployment
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #481:
URL: https://github.com/apache/tomcat/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org