You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mod_python-dev@quetz.apache.org by "Nicolas Lehuen (JIRA)" <ji...@apache.org> on 2005/01/31 21:19:17 UTC
[jira] Created: (MODPYTHON-17) Big marshalled cookies cause an error
Big marshalled cookies cause an error
-------------------------------------
Key: MODPYTHON-17
URL: http://issues.apache.org/jira/browse/MODPYTHON-17
Project: mod_python
Type: Bug
Versions: 3.1.3
Reporter: Nicolas Lehuen
Fix For: 3.1.4
[jira] Resolved: (MODPYTHON-17) Big marshalled cookies cause an error
Posted by "Nicolas Lehuen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/MODPYTHON-17?page=history ]
Nicolas Lehuen resolved MODPYTHON-17:
-------------------------------------
Assign To: Nicolas Lehuen
Resolution: Fixed
Fixed as proposed. Added a test for long marshalled cookies in the dedicated unit test.
> Big marshalled cookies cause an error
> -------------------------------------
>
> Key: MODPYTHON-17
> URL: http://issues.apache.org/jira/browse/MODPYTHON-17
> Project: mod_python
> Type: Bug
> Versions: 3.1.3
> Reporter: Nicolas Lehuen
> Assignee: Nicolas Lehuen
> Fix For: 3.1.4
>
> From the mailing list :
> While fiddling around with mod_pyhon 3.1.3 MarshalCookies and IE6, I
> noticed that once a cookie got to a certain size, it would stop being
> recognized as a valid Marshal cookie. I suspect (although I don't know
> for sure -- I'm not currently in a position to build mod_python) the
> problem is the following:
> In MarshalCookie's "def __str__(self):" method, base64.encodestring() is
> used to encode the cookie value. Unfortunately, base64.encodestring()
> adds newline characters to the byte stream every 76th byte, which seem
> to cause the problem. The terminal newline is stripped, but none of the
> internal ones.
> I would suggest that the line:
> m = base64.encodestring(marshal.dumps(self.value))[:-1]
> be replaced by something like:
> m = base64.encodestring(marshal.dumps(self.value))
> m = "".join(m.split("\n"))
> Regards, Steve McAdams
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (MODPYTHON-17) Big marshalled cookies cause an error
Posted by "Graham Dumpleton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/MODPYTHON-17?page=all ]
Graham Dumpleton closed MODPYTHON-17:
-------------------------------------
> Big marshalled cookies cause an error
> -------------------------------------
>
> Key: MODPYTHON-17
> URL: http://issues.apache.org/jira/browse/MODPYTHON-17
> Project: mod_python
> Type: Bug
> Versions: 3.1.3
> Reporter: Nicolas Lehuen
> Assignee: Nicolas Lehuen
> Fix For: 3.2.7
>
> From the mailing list :
> While fiddling around with mod_pyhon 3.1.3 MarshalCookies and IE6, I
> noticed that once a cookie got to a certain size, it would stop being
> recognized as a valid Marshal cookie. I suspect (although I don't know
> for sure -- I'm not currently in a position to build mod_python) the
> problem is the following:
> In MarshalCookie's "def __str__(self):" method, base64.encodestring() is
> used to encode the cookie value. Unfortunately, base64.encodestring()
> adds newline characters to the byte stream every 76th byte, which seem
> to cause the problem. The terminal newline is stripped, but none of the
> internal ones.
> I would suggest that the line:
> m = base64.encodestring(marshal.dumps(self.value))[:-1]
> be replaced by something like:
> m = base64.encodestring(marshal.dumps(self.value))
> m = "".join(m.split("\n"))
> Regards, Steve McAdams
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira