You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@zenplex.com> on 2003/03/12 16:32:08 UTC
Re: cvs commit:
jakarta-turbine-maven/src/java/org/apache/maven/plugin PluginManager.java
On Wed, 2003-03-12 at 10:28, dion@apache.org wrote:
> dion 2003/03/12 07:28:32
>
> Modified: src/java/org/apache/maven/plugin PluginManager.java
> Log:
> Silently ignore the missing project.xml
Sorry, but please back this out.
The CLI front-end should catch the non-existance of files as that's its
concern. Which has been fixed in the stuff I have.
> Revision Changes Path
> 1.42 +8 -5 jakarta-turbine-maven/src/java/org/apache/maven/plugin/PluginManager.java
>
> Index: PluginManager.java
> ===================================================================
> RCS file: /home/cvs/jakarta-turbine-maven/src/java/org/apache/maven/plugin/PluginManager.java,v
> retrieving revision 1.41
> retrieving revision 1.42
> diff -u -r1.41 -r1.42
> --- PluginManager.java 28 Feb 2003 00:48:39 -0000 1.41
> +++ PluginManager.java 12 Mar 2003 15:28:31 -0000 1.42
> @@ -359,11 +359,14 @@
> //if ( goalNames.size() == 1 )
> if ( project.getGoalNames().size() == 0 )
> {
> - String defaultGoalName = project.getContext().getWerkzProject().getDefaultGoalName();
> + if (project.getContext().getWerkzProject() != null)
> + {
> + String defaultGoalName = project.getContext().getWerkzProject().getDefaultGoalName();
>
> - if ( defaultGoalName != null )
> - {
> - project.getGoalNames().add( defaultGoalName );
> + if ( defaultGoalName != null )
> + {
> + project.getGoalNames().add( defaultGoalName );
> + }
> }
> }
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-maven-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-maven-dev-help@jakarta.apache.org
--
jvz.
Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
Re: cvs
commit: jakarta-turbine-maven/src/java/org/apache/maven/plugin
PluginManager.java
Posted by Jason van Zyl <ja...@zenplex.com>.
On Wed, 2003-03-12 at 10:54, dion@multitask.com.au wrote:
> Sure, it's been backed out.
>
> A few questions though:
>
> Jason van Zyl <ja...@zenplex.com> wrote on 13/03/2003 02:32:08 AM:
>
> > On Wed, 2003-03-12 at 10:28, dion@apache.org wrote:
> > > dion 2003/03/12 07:28:32
> > >
> > > Modified: src/java/org/apache/maven/plugin PluginManager.java
> > > Log:
> > > Silently ignore the missing project.xml
> >
> > Sorry, but please back this out.
> >
> > The CLI front-end should catch the non-existance of files as that's its
> > concern. Which has been fixed in the stuff I have.
>
> - When can we have your stuff in CVS?
Probably this weekend, I can't stop what I'm doing ATM.
> - Is it mandatory to have a project.xml? I've had a few cases where
> they're useless, and I've used maven just for scripting.
No, you don't need a project.xml currently. The 'genapp' goal is an
example of this where you can generate a skeletal app without a
project.xml file. It's invalid to have no project.xml and no goals
specified. This I have captured too, when this occurs help is now
displayed.
> --
> dIon Gillard, Multitask Consulting
> Blog: http://www.freeroller.net/page/dion/Weblog
> Work: http://www.multitask.com.au
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-maven-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-maven-dev-help@jakarta.apache.org
--
jvz.
Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
Re: cvs commit: jakarta-turbine-maven/src/java/org/apache/maven/plugin
PluginManager.java
Posted by di...@multitask.com.au.
Sure, it's been backed out.
A few questions though:
Jason van Zyl <ja...@zenplex.com> wrote on 13/03/2003 02:32:08 AM:
> On Wed, 2003-03-12 at 10:28, dion@apache.org wrote:
> > dion 2003/03/12 07:28:32
> >
> > Modified: src/java/org/apache/maven/plugin PluginManager.java
> > Log:
> > Silently ignore the missing project.xml
>
> Sorry, but please back this out.
>
> The CLI front-end should catch the non-existance of files as that's its
> concern. Which has been fixed in the stuff I have.
- When can we have your stuff in CVS?
- Is it mandatory to have a project.xml? I've had a few cases where
they're useless, and I've used maven just for scripting.
--
dIon Gillard, Multitask Consulting
Blog: http://www.freeroller.net/page/dion/Weblog
Work: http://www.multitask.com.au