You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/03/25 21:35:04 UTC
[GitHub] incubator-zeppelin pull request: Pull request merge tool
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/3
Pull request merge tool
Since apache/incubator-zeppelin is a mirror, we can not simply click merge button for pull request.
Here's pullrequest merge tool, i modified little bit for Zeppelin, based on Spark's one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/incubator-zeppelin merge_tool
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 1a70af5b842b85efe24752646e03a93c45e32cf4
Author: Lee moon soo <mo...@apache.org>
Date: 2015-03-25T20:29:52Z
Add pull request merge tool
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86875491
:+1: @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86325370
@jongyoul Thanks for correction.
@corneadoug
To use this script, minimum requirements are
1. you should inside of Zeppelin source directory (or setup ZEPPELIN_HOME env variable)
2. add remote repository https://github.com/apache/incubator-zeppelin.git with name 'apache-github' and fetch it (you can use your favorite name instead of 'apache-github' with PR_REMOTE_NAME env variable)
3. add remote repository https://git-wip-us.apache.org/repos/asf/incubator-zeppelin with name 'apache' and fetch it (you can use your favorite name instead of 'apache' with PUSH_REMOTE_NAME env variable)
You can optionally setup your JIRA account by setting up JIRA_USERNAME, JIRA_PASSWORD env variable.
and just run the script. script will ask question what you want to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86257890
Is there some options to pass also? Or does everybody has to configure its own?
I see that JIRA_USERNAME and JIRA_PASSWORD for example.
Can you make a quick HOW TO USE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86295086
Right, it's modification of spark's one.
And thanks for the feedback, but I still prefer to Spark's one over mesos's. The reasons are
* Spark's one comments all authors in pull requests when pull requests has commits from more than two contributors while mesos's one does not.
* Spark's one summarize all commits with author for the reference, while mesos's one is not.
* Mesos's one creates link to review board, which Zeppelin development community is not using it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86950234
Thanks. I'm merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86790182
@Leemoonsoo thank you very much for the tutorial!
As we can always switch, why not we try Spark one first and see? If that does not work for us, let's then try mesos one.
So my suggestion would be to merge this and move on.
BTW I presume each committee could use even his own tool of choice if it follows the process (i.e make reviews-before-commit in GH PRs and not a reviewboard)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86870146
Like @bzz suggested, I think we can first try spark's one and see how it goes. @anthonycorbacho @jongyoul, is it okay for you guys?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86305741
Yes, some are rights. Mesos' one doesn't support multiple author, but I think It's rare case. And in case you choose github for merging source, Mesos's doesn't create any reviewboard link whether Zeppelin use it or not. If you need to support mutiple authors, Spark's one would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86266392
This looks like the modified version of spark_merge_pr.py, isn't it? I survey several merging tool for ASF. Do you try to get Mesos' one? https://github.com/apache/mesos/blob/master/support/apply-review.sh I think it's really clear to read code. How about you? Spark's one looks a little bit complicated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86278760
I like more the mesos `apply-review.sh`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pull request merge tool
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/3#issuecomment-86887701
yep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---