You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/28 11:39:20 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7584: [AIRFLOW-6956]
Extract kill_child_processes_by_pids from DagFileProcessorManager
mik-laj opened a new pull request #7584: [AIRFLOW-6956] Extract kill_child_processes_by_pids from DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7584
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7584: [AIRFLOW-6956] Extract
kill_child_processes_by_pids from DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7584: [AIRFLOW-6956] Extract kill_child_processes_by_pids from DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7584: [AIRFLOW-6956]
Extract kill_child_processes_by_pids from DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7584: [AIRFLOW-6956] Extract kill_child_processes_by_pids from DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7584#issuecomment-592517938
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=h1) Report
> Merging [#7584](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/008b4bab14222da068b737d6332db4963b994007?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7584 +/- ##
==========================================
+ Coverage 86.57% 86.59% +0.01%
==========================================
Files 896 896
Lines 42622 42625 +3
==========================================
+ Hits 36902 36913 +11
+ Misses 5720 5712 -8
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `89.55% <50%> (+2.95%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `80.55% <65%> (-19.45%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.48% <0%> (-0.31%)` | :arrow_down: |
| [...rflow/providers/apache/spark/hooks/spark\_submit.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX3N1Ym1pdC5weQ==) | `84.67% <0%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=footer). Last update [008b4ba...bf8f404](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7584: [AIRFLOW-6956] Extract
kill_child_processes_by_pids from DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7584: [AIRFLOW-6956] Extract kill_child_processes_by_pids from DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7584#issuecomment-592989174
Do you have any specific example? Many operations are available via a nice API in the psutil library. Some operations have system APIs, e.g. os.kill, so they don't have to be in utils. I found one function - `reap_process_group` that could be moved to this module and I will try to do it in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7584:
[AIRFLOW-6956] Extract kill_child_processes_by_pids from
DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7584: [AIRFLOW-6956] Extract kill_child_processes_by_pids from DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7584#issuecomment-592517938
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=h1) Report
> Merging [#7584](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1d16de7af0ba0b6c8493b105a6751693d2ef30f2?src=pr&el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `85%`.
[](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7584 +/- ##
==========================================
- Coverage 86.81% 86.58% -0.24%
==========================================
Files 896 897 +1
Lines 42704 42747 +43
==========================================
- Hits 37074 37011 -63
- Misses 5630 5736 +106
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `89.57% <50%> (+2.92%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `73.25% <88.88%> (+4.13%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `64.28% <0%> (-1.76%)` | :arrow_down: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.55% <0%> (-0.03%)` | :arrow_down: |
| [airflow/utils/log/cloudwatch\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7584/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY2xvdWR3YXRjaF90YXNrX2hhbmRsZXIucHk=) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=footer). Last update [1d16de7...7d83211](https://codecov.io/gh/apache/airflow/pull/7584?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services