You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@redhat.com> on 2012/11/14 05:14:49 UTC
Request for feature inclusion in 0.20 - initial phase of listening
to specificied network interfaces
As you might see from my message to the user list I've been working on
restricting the broker from always listening on every network interface.
The work is in two phases:
First, just specifying the network interfaces to listen on and using
both the default specified tcp and ssl ports on those interfaces.
Second, allowing the specification of a port as well in which case you
listen on that interface/port for both regular tcp and ssl.
[And probably thirdly, some way of restricting interface/ports to just
ssl/regular tcp)
I've finished work on the first part - it's backward compatible - if you
don't specify the new "interface" option then no behaviour is changed.
The changes are very localised to 2 files and so I think they are pretty
low risk. There are 3 other files with some extra functionality too, but
I think you can trivially see that this is safe if it is not used
(mostly just new functions only used in the new functionality).
The second stage will require a bit of refactoring that I have avoiding
in the first stage by using a little more cut-and-paste programming than
I like, but in this case it keeps the changes simple to follow.
You can inspect the changes by looking at my git repo on github:
https://github.com/astitcher/qpid/commits/netinterfaces
I realise it's pretty late in the beta process for this to be going in,
but I think that it has significant value even incomplete with little
risk.
Andrew
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: Request for feature inclusion in 0.20 - initial phase of listening
to specificied network interfaces
Posted by Justin Ross <jr...@redhat.com>.
I've reviewed this and spoken to Andrew about it. I favor including this
for 0.20.
Justin
On Tue, 13 Nov 2012, Andrew Stitcher wrote:
> As you might see from my message to the user list I've been working on
> restricting the broker from always listening on every network interface.
>
> The work is in two phases:
>
> First, just specifying the network interfaces to listen on and using
> both the default specified tcp and ssl ports on those interfaces.
>
> Second, allowing the specification of a port as well in which case you
> listen on that interface/port for both regular tcp and ssl.
>
> [And probably thirdly, some way of restricting interface/ports to just
> ssl/regular tcp)
>
> I've finished work on the first part - it's backward compatible - if you
> don't specify the new "interface" option then no behaviour is changed.
> The changes are very localised to 2 files and so I think they are pretty
> low risk. There are 3 other files with some extra functionality too, but
> I think you can trivially see that this is safe if it is not used
> (mostly just new functions only used in the new functionality).
>
> The second stage will require a bit of refactoring that I have avoiding
> in the first stage by using a little more cut-and-paste programming than
> I like, but in this case it keeps the changes simple to follow.
>
> You can inspect the changes by looking at my git repo on github:
> https://github.com/astitcher/qpid/commits/netinterfaces
>
> I realise it's pretty late in the beta process for this to be going in,
> but I think that it has significant value even incomplete with little
> risk.
>
> Andrew
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org