You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/27 22:09:14 UTC

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3514

to review the following change.

Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp
......................................................................

ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

This test seems to be flaky due to not waiting long enough for the TS to crash.
I tried to repro on dist-test, but the GCE test slaves are fast enough that it
passed 1000/1000. On EC2 apparently things are a little slower so 10 seconds
isn't enough time to guarantee that the injected fault fires.

Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/3514/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2055/

-- 
To view, visit http://gerrit.cloudera.org:8080/3514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp
......................................................................


ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

This test seems to be flaky due to not waiting long enough for the TS to crash.
I tried to repro on dist-test, but the GCE test slaves are fast enough that it
passed 1000/1000. On EC2 apparently things are a little slower so 10 seconds
isn't enough time to guarantee that the injected fault fires.

Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
Reviewed-on: http://gerrit.cloudera.org:8080/3514
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No