You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/23 21:27:32 UTC

[kudu-CR] [client] add logging on slow metacache operations

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17221


Change subject: [client] add logging on slow metacache operations
......................................................................

[client] add logging on slow metacache operations

This patch adds 50ms threshold slow logging for metacache operations:
  * ProcessGetTableLocationsResponse
  * ProcessGetTabletLocationsResponse
  * LookupEntryByIdFastPath
  * LookupEntryByKeyFastPath

Change-Id: I5eb0593794f9a971f3daea7d346f70b0dc32bfa7
---
M src/kudu/client/meta_cache.cc
1 file changed, 12 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/17221/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb0593794f9a971f3daea7d346f70b0dc32bfa7
Gerrit-Change-Number: 17221
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [client] add logging on slow metacache operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17221 )

Change subject: [client] add logging on slow metacache operations
......................................................................

[client] add logging on slow metacache operations

This patch adds 50ms threshold slow logging for metacache operations:
  * ProcessGetTableLocationsResponse
  * ProcessGetTabletLocationsResponse
  * LookupEntryByIdFastPath
  * LookupEntryByKeyFastPath

Change-Id: I5eb0593794f9a971f3daea7d346f70b0dc32bfa7
Reviewed-on: http://gerrit.cloudera.org:8080/17221
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/client/meta_cache.cc
1 file changed, 12 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb0593794f9a971f3daea7d346f70b0dc32bfa7
Gerrit-Change-Number: 17221
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [client] add logging on slow metacache operations

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17221 )

Change subject: [client] add logging on slow metacache operations
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb0593794f9a971f3daea7d346f70b0dc32bfa7
Gerrit-Change-Number: 17221
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Mar 2021 12:43:41 +0000
Gerrit-HasComments: No