You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 22:11:18 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #17702: Add steps for building release package without breeze.
jhtimmins opened a new pull request #17702:
URL: https://github.com/apache/airflow/pull/17702
Breeze typically handles converting a release tarball into distribution and wheel files. If Breeze isn't working on your machine, or you just aren't using it, `python setup.py compile_assets sdist bdist_wheel` works for creating the files.
This adds that step to the release docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17702: Add steps for building release package without breeze.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17702:
URL: https://github.com/apache/airflow/pull/17702#discussion_r691640009
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -115,14 +115,19 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
-o dist/apache-airflow-${VERSION_WITHOUT_RC}-source.tar.gz
```
-
- Generate SHA512/ASC (If you have not generated a key yet, generate it by following instructions on http://www.apache.org/dev/openpgp.html#key-gen-generate-key)
```shell script
./breeze prepare-airflow-packages --package-format both
${AIRFLOW_REPO_ROOT}/dev/sign.sh dist/*
```
+- If you aren't using Breeze for packaging, build the distribution and wheel files directly
+
+ ```shell script
+ python setup.py compile_assets sdist bdist_wheel
Review comment:
```suggestion
python setup.py compile_assets sdist bdist_wheel
${AIRFLOW_REPO_ROOT}/dev/sign.sh dist/*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17702: Add steps for building release package without breeze.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17702:
URL: https://github.com/apache/airflow/pull/17702#discussion_r691640282
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -115,14 +115,19 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
-o dist/apache-airflow-${VERSION_WITHOUT_RC}-source.tar.gz
```
-
- Generate SHA512/ASC (If you have not generated a key yet, generate it by following instructions on http://www.apache.org/dev/openpgp.html#key-gen-generate-key)
```shell script
./breeze prepare-airflow-packages --package-format both
${AIRFLOW_REPO_ROOT}/dev/sign.sh dist/*
```
+- If you aren't using Breeze for packaging, build the distribution and wheel files directly
+
+ ```shell script
+ python setup.py compile_assets sdist bdist_wheel
Review comment:
That will sign the dist.. or may be separate the signing step from L122 and here to a separate point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #17702: Add steps for building release package without breeze.
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #17702:
URL: https://github.com/apache/airflow/pull/17702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17702: Add steps for building release package without breeze.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17702:
URL: https://github.com/apache/airflow/pull/17702#issuecomment-901464130
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org