You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/20 02:56:50 UTC
[GitHub] [arrow] houqp opened a new pull request #7501: run clippy to lint arrow crate in CI
houqp opened a new pull request #7501:
URL: https://github.com/apache/arrow/pull/7501
The goal of this PR is not to fix all the clippy errors/warnings, but to make sure no new linting errors are introduced in the future so we can slowly fix the remaining errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-652770694
@kszucs gentle ping, let me know what's the best way for me to help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-648562595
Hm I think this lint step should be merged into the main Lint workflow. @kszucs can you help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-652877301
> Hm I think this lint step should be merged into the main Lint workflow. @kszucs can you help?
It would be nice to have it integrated to archery, but since it's only triggered for the rust changes I think it's fine to defer it to a follow-up.
Created ARROW-9295: [Archery] Support rust clippy in the lint command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #7501: ARROW-9192: [CI][Rust] Add support for running clippy
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-653175026
Thanks @kszucs , at the mean time, I will try to fix more linting errors and see if we can just run clippy as is without the custom linting script before you start adding it to Archery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-652882320
@houqp sorry for the late response. I moved the lint job to the macos build to spare some CI resource and also changed to check all crates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp closed pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
houqp closed pull request #7501:
URL: https://github.com/apache/arrow/pull/7501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-646927676
https://issues.apache.org/jira/browse/ARROW-9192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-648576776
@kszucs let me know if there is anything i can help to move it to the main lint workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7501: ARROW-9192: [CI][Rust] Add support for running clippy
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-652884516
Created another follow-up to enable more clippy rules: ARROW-9296: [CI][Rust] Enable more clippy lint checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #7501: ARROW-9192: [CI][Rust] Add support for running clippy
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #7501:
URL: https://github.com/apache/arrow/pull/7501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org