You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/04 08:43:39 UTC

Review Request 35048: DRILL-2089: Part 3--Move files. (Move _only_--no edits (e.g., package renaming).)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35048/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2089
    https://issues.apache.org/jira/browse/DRILL-2089


Repository: drill-git


Description
-------

Moved files from exec/jdbc/src/main/java/org/apache/drill/jdbc/
              to exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/:
- AvaticaDrillSqlAccessor.java
- BasicList.java
- DrillAccessorList.java
- DrillColumnMetaDataList.java
- DrillConnectionImpl.java
- DrillCursor.java
- DrillDatabaseMetaData.java
- DrillFactory.java
- DrillHandler.java
- DrillJdbc40Factory.java
- DrillJdbc41Factory.java
- DrillPrepareResult.java
- DrillPreparedStatement.java
- DrillRemoteStatement.java
- DrillStatementRegistry.java
- DriverImpl.java
- GlobalServiceSetReference.java
- MetaImpl.java


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java f5aa3b7 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/BasicList.java 290d680 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java b31efb1 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillColumnMetaDataList.java 40c7ae7 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java e2dea4c 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillHandler.java 592bff3 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc40Factory.java b542eb2 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPrepareResult.java a388c4e 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java 4397c2f 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillRemoteStatement.java e19b49d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java fb38e31 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DriverImpl.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/GlobalServiceSetReference.java 7c9329c 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 2ac0b91 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/BasicList.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35048/diff/


Testing
-------

Ran existing tests.  (With parts 1 through 7 together.)


Thanks,

Daniel Barclay


Re: Review Request 35048: DRILL-2089: Part 3--Move files. (Move _only_--no edits (e.g., package renaming).)

Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35048/#review87288
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35048/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 6:43 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2089
>     https://issues.apache.org/jira/browse/DRILL-2089
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Moved files from exec/jdbc/src/main/java/org/apache/drill/jdbc/
>               to exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/:
> - AvaticaDrillSqlAccessor.java
> - BasicList.java
> - DrillAccessorList.java
> - DrillColumnMetaDataList.java
> - DrillConnectionImpl.java
> - DrillCursor.java
> - DrillDatabaseMetaData.java
> - DrillFactory.java
> - DrillHandler.java
> - DrillJdbc40Factory.java
> - DrillJdbc41Factory.java
> - DrillPrepareResult.java
> - DrillPreparedStatement.java
> - DrillRemoteStatement.java
> - DrillStatementRegistry.java
> - DriverImpl.java
> - GlobalServiceSetReference.java
> - MetaImpl.java
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java f5aa3b7 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/BasicList.java 290d680 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java b31efb1 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillColumnMetaDataList.java 40c7ae7 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java e2dea4c 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillHandler.java 592bff3 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc40Factory.java b542eb2 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPrepareResult.java a388c4e 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java 4397c2f 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillRemoteStatement.java e19b49d 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java fb38e31 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DriverImpl.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/GlobalServiceSetReference.java 7c9329c 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 2ac0b91 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/BasicList.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35048/diff/
> 
> 
> Testing
> -------
> 
> Ran existing tests.  (With parts 1 through 7 together.)
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>