You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/10/06 23:35:38 UTC
(texera) branch main updated (9a427ccfc8 -> b76048948b)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
from 9a427ccfc8 fix(frontend): list a version's files when the Versions & Files tab opens (#8838)
new 007bf4328a refactor(frontend): remove the dead console-frame error style (#8881)
new b76048948b refactor(pyamber): remove the unused R TypeVar (#8877)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/python/core/architecture/rpc/async_rpc_client.py | 4 +---
.../result-panel/console-frame/console-frame.component.scss | 10 ----------
2 files changed, 1 insertion(+), 13 deletions(-)
(texera) 02/02: refactor(pyamber): remove the unused R TypeVar (#8877)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
commit b76048948b64e9aa87509c627700f5573c955508
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Tue Oct 6 23:16:44 2026 +0000
refactor(pyamber): remove the unused R TypeVar (#8877)
### What changes were proposed in this PR?
Removes the unused `R = TypeVar("R")` from pyamber's
`async_rpc_client.py`, and drops `TypeVar` from its `typing` import,
which only existed for it. **+1/−3 lines.** There is no behaviour
change: nothing in the file refers to `R`, and the module's two
importers (`main_loop.py` and its test) import only `AsyncRPCClient` and
`async_run`.
### History
| | |
| --- | --- |
| **Introduced by** | #2950 (2024-10-31), "Migrate scala control
messages to protobuf", together with the `TypeVar` import |
| **Usage removed by** | **never used**. No annotation, `Generic[R]` or
string annotation has ever referred to it |
It has been unused for the eleven months since it was added.
### Any related issues, documentation, discussions?
Closes #8876
### How was this PR tested?
No new tests.
From `amber/`:
- `ruff check src/main/python src/test/python && ruff format --check
src/main/python src/test/python`: clean.
- `python -m pytest -m "not integration"
src/test/python/core/architecture/rpc/test_async_rpc_client.py`: 12
tests, all pass.
To re-check:
```
git grep -n 'TypeVar("R")' # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
amber/src/main/python/core/architecture/rpc/async_rpc_client.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/amber/src/main/python/core/architecture/rpc/async_rpc_client.py b/amber/src/main/python/core/architecture/rpc/async_rpc_client.py
index 98104dbc42..5da6c7d3e3 100644
--- a/amber/src/main/python/core/architecture/rpc/async_rpc_client.py
+++ b/amber/src/main/python/core/architecture/rpc/async_rpc_client.py
@@ -21,7 +21,7 @@ from collections import defaultdict
from concurrent.futures import Future
from functools import wraps
from loguru import logger
-from typing import Dict, TypeVar, Callable, Any, Coroutine
+from typing import Dict, Callable, Any, Coroutine
from core.architecture.managers.context import Context
from core.models.internal_queue import InternalQueue, DCMElement
@@ -37,8 +37,6 @@ from proto.org.apache.texera.amber.engine.architecture.rpc import (
)
from proto.org.apache.texera.amber.engine.common import DirectControlMessagePayloadV2
-R = TypeVar("R")
-
def async_run(func: Callable[..., Any]) -> Callable[..., Any]:
@wraps(func)
(texera) 01/02: refactor(frontend): remove the dead console-frame error style (#8881)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
commit 007bf4328a2d0fdc9b0930eb6478e800db28e90c
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Tue Oct 6 23:16:23 2026 +0000
refactor(frontend): remove the dead console-frame error style (#8881)
### What changes were proposed in this PR?
Removes the `.error-message` rule from the console panel's stylesheet
(`console-frame.component.scss`), which styles nothing. **−10 lines.**
There is no behaviour change. The component uses emulated encapsulation,
its template has no `error-message` class (static or dynamic), its TS
adds no classes at runtime, and its ng-zorro children never render one.
### History
| | |
| --- | --- |
| **Introduced by** | #1304 (2021-08-20), "Properly update ConsoleFrame
when state changes", with a `<div class="error-message">` listing
operator errors |
| **Usage removed by** | #2195 (2023-11-09), "Enhance frontend error
reporting". It moved error display out of the console frame and deleted
that element |
It has been dead for nearly three years.
### Any related issues, documentation, discussions?
Closes #8880
### How was this PR tested?
No new tests; no spec referenced the class.
From `frontend/`:
- `npx ng test --watch=false
--include='**/console-frame.component.spec.ts'
--include='**/result-panel.component.spec.ts'`: 2 files, 105 tests, all
pass. The result-panel spec renders the console frame.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
.../result-panel/console-frame/console-frame.component.scss | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss b/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
index 358c7bf8ed..6bd09740b8 100644
--- a/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
+++ b/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
@@ -27,16 +27,6 @@
user-select: text;
}
-.error-message {
- font-family: monaco, serif;
- font-size: 11px;
- font-style: normal;
- font-variant: normal;
- font-weight: 200;
- line-height: 14px;
- color: red;
-}
-
.console-toolbar {
flex: 0 0 auto;
display: flex;