You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/13 02:39:09 UTC

[GitHub] [dubbo-go] wangxw666 opened a new pull request #1317: fix #1311

wangxw666 opened a new pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] wangxw666 commented on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
wangxw666 commented on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-882285907


   > dubbogo.registry.service
   > 加这一字段的目的是什么？可以考虑在应用侧放到param里面，参考 https://github.com/apache/dubbo-go-samples/blob/0a1f5a414569d52eca4d8af18b6c9229b2bbe437/router/uniform-router/file/go-server/conf/server.yml#L27
   
   registryprotocol中注册中心实例的缓存的key是固定的，等到registry层流程完毕，就会替换为具体服务的接口名。
   
   registry 注册中心层：封装服务地址的注册与发现，以服务 URL 为中心，扩展接口为 RegistryFactory, Registry, RegistryService
   
   例如在dubbo中注册中心缓存的key为RegistryService.class name，这个是不需要用户配置的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] wangxw666 closed pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
wangxw666 closed pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-881831672


   dubbogo.registry.service
   加这一字段的目的是什么？可以考虑在应用侧放到param里面，参考    https://github.com/apache/dubbo-go-samples/blob/0a1f5a414569d52eca4d8af18b6c9229b2bbe437/router/uniform-router/file/go-server/conf/server.yml#L27


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-878737846


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1317](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cedd6ab) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.54%`.
   > The diff coverage is `53.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1317/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1317      +/-   ##
   ==========================================
   - Coverage   56.09%   55.55%   -0.55%     
   ==========================================
     Files         273      273              
     Lines       12779    15027    +2248     
   ==========================================
   + Hits         7169     8348    +1179     
   - Misses       4705     5763    +1058     
   - Partials      905      916      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `51.34% <0.00%> (+3.97%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.29% <0.00%> (-0.53%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `54.74% <0.00%> (-0.67%)` | :arrow_down: |
   | [...ta/service/local/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `85.10% <ø> (ø)` | |
   | [metadata/service/local/service\_proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlX3Byb3h5Lmdv) | `63.85% <ø> (ø)` | |
   | [...y/event/service\_instances\_changed\_listener\_impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvc2VydmljZV9pbnN0YW5jZXNfY2hhbmdlZF9saXN0ZW5lcl9pbXBsLmdv) | `0.00% <0.00%> (ø)` | |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `79.41% <66.66%> (+3.54%)` | :arrow_up: |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21e9f4e...cedd6ab](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-885504342


   请合并一下3.0分支，可以通过ci测试。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-878737846


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1317](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cedd6ab) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.54%`.
   > The diff coverage is `53.84%`.
   
   > :exclamation: Current head cedd6ab differs from pull request most recent head ac52b22. Consider uploading reports for the commit ac52b22 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1317/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1317      +/-   ##
   ==========================================
   - Coverage   56.09%   55.55%   -0.55%     
   ==========================================
     Files         273      273              
     Lines       12779    15027    +2248     
   ==========================================
   + Hits         7169     8348    +1179     
   - Misses       4705     5763    +1058     
   - Partials      905      916      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `51.34% <0.00%> (+3.97%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.29% <0.00%> (-0.53%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `54.74% <0.00%> (-0.67%)` | :arrow_down: |
   | [...ta/service/local/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `85.10% <ø> (ø)` | |
   | [metadata/service/local/service\_proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlX3Byb3h5Lmdv) | `63.85% <ø> (ø)` | |
   | [...y/event/service\_instances\_changed\_listener\_impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvc2VydmljZV9pbnN0YW5jZXNfY2hhbmdlZF9saXN0ZW5lcl9pbXBsLmdv) | `0.00% <0.00%> (ø)` | |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `79.41% <66.66%> (+3.54%)` | :arrow_up: |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21e9f4e...ac52b22](https://codecov.io/gh/apache/dubbo-go/pull/1317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1317: fix #1311

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1317:
URL: https://github.com/apache/dubbo-go/pull/1317#issuecomment-895731664


   Please check your ut. @wangxw666 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org