[jira] [Closed] (TINKERPOP-1243) MatchStep should be a FilterStep, not a MapStep

["Marko A. Rodriguez (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TINKERPOP-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marko A. Rodriguez closed TINKERPOP-1243.
-----------------------------------------
    Resolution: Invalid
      Assignee: Marko A. Rodriguez

This is a nice idea, but the problem, {{MatchStep}} is actually a {{FlatMapStep}} as it "flatmaps out" pattern matches given the input. If we are going to do anything in the spirit of this ticket, it should be that the input is returned, NOT a {{Map<String,Object>}} (that is what {{select()}} is for). I will close this ticket as invalid and if we wish later on, we can remove the {{Map<String,Object>}} mapping in another ticket.

> MatchStep should be a FilterStep, not a MapStep
> -----------------------------------------------
>
>                 Key: TINKERPOP-1243
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1243
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.1-incubating, 3.2.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>              Labels: breaking
>
> {{MatchStep}} should really be a {{FilterStep}}. It simply filters out all traversers that don't match the patterns. However, given that you typically {{select()}} after {{match()}}, a {{Map<String,Object>}} is generated. The benefit of making it a {{FilterStep}} is that people can use {{match()}} to filter without having to deal with unrolling the {{Map}}. Moreover, it feels more consistent with the language constructs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)