Re: [jclouds/jclouds] Fix/azure resource removal (#1240)

[Martin Harris <no...@github.com>]

nakomis commented on this pull request.



> +      // Wait for 404 on the disk api
+      Predicate<IdReference> diskDeleted = new Predicate<IdReference>() {
+         @Override
+         public boolean apply(IdReference input) {
+            return api.getDiskApi(input.resourceGroup()).get(input.name()) == null;
+         }
+      };
+
+      Predicate<IdReference> filter = retry(diskDeleted, 1200, 5, 15, SECONDS);
+      Set<IdReference> nonDeleted = Sets.filter(deleteDisks, filter);
+
+      if (!nonDeleted.isEmpty()) {
+         logger.warn(">> disks not deleted: %s", Joiner.on(',').join(nonDeleted));
+      }
+
+      Set<IdReference> disksNotInRg = Sets.filter(deleteDisks, resourceRemoved);

Hi @nacx The call to the predicate causes the method to block until the resource has been removed from the resource group (in addition to being deleted), so it is always necessary to call it

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#discussion_r235383608