You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by ar...@apache.org on 2019/04/08 10:40:59 UTC

[drill] 06/06: DRILL-7045: Updates to address review comments

This is an automated email from the ASF dual-hosted git repository.

arina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git

commit 771fd270b684bbf388c0e2fa10b359eba3dfdb7c
Author: Sorabh Hamirwasia <so...@apache.org>
AuthorDate: Tue Apr 2 13:24:59 2019 -0700

    DRILL-7045: Updates to address review comments
    
    closes #7134
---
 .../drill/exec/vector/complex/writer/TestJsonNanInf.java      | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java b/exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java
index 851ce0e..b7b3744 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java
@@ -18,15 +18,15 @@
 package org.apache.drill.exec.vector.complex.writer;
 
 import org.apache.commons.io.FileUtils;
-import org.apache.drill.exec.physical.impl.join.JoinTestBase;
-import org.apache.drill.test.BaseTestQuery;
 import org.apache.drill.common.exceptions.UserRemoteException;
 import org.apache.drill.common.expression.SchemaPath;
 import org.apache.drill.exec.ExecConstants;
+import org.apache.drill.exec.physical.impl.join.JoinTestBase;
 import org.apache.drill.exec.record.RecordBatchLoader;
 import org.apache.drill.exec.record.VectorWrapper;
 import org.apache.drill.exec.rpc.user.QueryDataBatch;
 import org.apache.drill.exec.vector.VarCharVector;
+import org.apache.drill.test.BaseTestQuery;
 import org.junit.Ignore;
 import org.junit.Test;
 
@@ -244,12 +244,7 @@ public class TestJsonNanInf extends BaseTestQuery {
       builder.append(chunk);
     }
     String data = builder.toString();
-    String query = String.format("select string_binary(binary_string('%s')) from (values(1))", data);
-    List<QueryDataBatch> results = testSqlWithResults(query);
-    RecordBatchLoader batchLoader = new RecordBatchLoader(getAllocator());
-    QueryDataBatch batch = results.get(0);
-    batch.release();
-    batchLoader.clear();
+    test("select string_binary(binary_string('%s')) from (values(1))", data);
  }
 
   @Test