You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/11 07:41:14 UTC
[GitHub] [spark] peter-toth opened a new pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
peter-toth opened a new pull request #29727:
URL: https://github.com/apache/spark/pull/29727
### What changes were proposed in this pull request?
This is a follow up to https://github.com/apache/spark/pull/29572.
LeftAnti SortMergeJoin should not buffer all matching right side rows when bound condition is empty, this is unnecessary and can lead to performance degradation especially when spilling happens.
### Why are the changes needed?
Performance improvement.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
**[Test build #128561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128561/testReport)** for PR 29727 at commit [`8f048ee`](https://github.com/apache/spark/commit/8f048ee915636a2c4843945f3fa88f100402c002).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29727:
URL: https://github.com/apache/spark/pull/29727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933379
cc @cloud-fan, @juliuszsompolski, @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29727:
URL: https://github.com/apache/spark/pull/29727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691102737
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691071814
**[Test build #128561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128561/testReport)** for PR 29727 at commit [`8f048ee`](https://github.com/apache/spark/commit/8f048ee915636a2c4843945f3fa88f100402c002).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691102737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29727:
URL: https://github.com/apache/spark/pull/29727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691102737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691102737
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691072846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29727:
URL: https://github.com/apache/spark/pull/29727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-691072846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29727: [SPARK-32730][SQL][FOLLOW-UP] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690932636
**[Test build #128561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128561/testReport)** for PR 29727 at commit [`8f048ee`](https://github.com/apache/spark/commit/8f048ee915636a2c4843945f3fa88f100402c002).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29727: [SPARK-32730][SQL] Improve LeftAnti SortMergeJoin right side buffering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29727:
URL: https://github.com/apache/spark/pull/29727#issuecomment-690933238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org