You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/28 18:01:56 UTC

[GitHub] [tvm] tkonolige opened a new pull request #7939: [FIX] Fix deploy_sparse tutorial

tkonolige opened a new pull request #7939:
URL: https://github.com/apache/tvm/pull/7939


   @areusch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jroesch commented on pull request #7939: [FIX] Fix deploy_sparse tutorial

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #7939:
URL: https://github.com/apache/tvm/pull/7939#issuecomment-830466857


   @tkonolige @areusch can you guys get this green and land?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7939: [FIX] Fix deploy_sparse tutorial

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7939:
URL: https://github.com/apache/tvm/pull/7939#issuecomment-830651571


   @tkonolige i see, so the problem is that gen_weights was False here? basically my only concern is whether we need to make a more fundamental change to params to fix common use case, at least we should understand and document that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #7939: [FIX] Fix deploy_sparse tutorial

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7939:
URL: https://github.com/apache/tvm/pull/7939#issuecomment-831351159


   The issue is that `load_param_dict` returns a `Map` which does not support mutation from python. I better fix may be to switch `load_param_dict` to returning a `dict` or allow mutation of `Map` from python.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7939: [FIX] Fix deploy_sparse tutorial

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7939:
URL: https://github.com/apache/tvm/pull/7939#issuecomment-831371358


   yeah just wanted to understand why this changed recently, but now i see the tutorial doesn't actually run in CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #7939: [FIX] Fix deploy_sparse tutorial

Posted by GitBox <gi...@apache.org>.
areusch merged pull request #7939:
URL: https://github.com/apache/tvm/pull/7939


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org