You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/22 14:53:00 UTC
[jira] [Work logged] (BEAM-14144) Record JFR profiles when GC thrashing is detected
[ https://issues.apache.org/jira/browse/BEAM-14144?focusedWorklogId=745862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745862 ]
ASF GitHub Bot logged work on BEAM-14144:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/22 14:52
Start Date: 22/Mar/22 14:52
Worklog Time Spent: 10m
Work Description: steveniemitz opened a new pull request #17151:
URL: https://github.com/apache/beam/pull/17151
This has been incredibly helpful for debugging performance issues (specifically GC related) in jobs. When GC thrashing is detected, we now record a JFR profile (for a duration set by `--jfrRecordingDurationSec`, 60 seconds by default) and upload it to GCS (to the same path as set by `--saveHeapDumpsToGcsPath`).
Again not sure who to get to review this, @lukecwik maybe you or you can pass it off to someone else?
Also, side note, it looks like this class also now exists in the FnHarness code too. I didn't update it there, but would be happy to integrate these changes there in another review.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 745862)
Remaining Estimate: 0h
Time Spent: 10m
> Record JFR profiles when GC thrashing is detected
> -------------------------------------------------
>
> Key: BEAM-14144
> URL: https://issues.apache.org/jira/browse/BEAM-14144
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It'd be useful for debugging GC issues in jobs to have allocation profiles when it was occurring. In java 9+, JFR is included in the JDK, we could use that to record profiles when GC thrashing is detected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)