[GitHub] [superset] mayurnewase commented on a diff in pull request #22196: fix(reports): force data generation in csv reports

[GitBox <gi...@apache.org>]

mayurnewase commented on code in PR #22196:
URL: https://github.com/apache/superset/pull/22196#discussion_r1029960563


##########
superset/charts/data/api.py:
##########
@@ -130,6 +135,7 @@ def get_data(self, pk: int) -> Response:
             "format", ChartDataResultFormat.JSON
         )
         json_body["result_type"] = request.args.get("type", ChartDataResultType.FULL)
+        json_body["force"] = request.args.get("force", False)

Review Comment:
   umm I think that is taken care by `_create_query_context_from_form` function below using mashmallow schema's load function.
   I tested with false too and it's working as expected, do you still need this conversion here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org