You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "infdahai (via GitHub)" <gi...@apache.org> on 2023/05/18 15:40:18 UTC
[GitHub] [incubator-kvrocks] infdahai opened a new issue, #1445: Add support of the `BZMPOP` command
infdahai opened a new issue, #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
This issue considers to support [`bzmpop`](https://redis.io/commands/bzmpop/), `bzmpopmax`, `bzpopmin` commands.
And the implementation shoule process a `timeout` argument.
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1564280698
Ok, I'm already in the group and i'll look into the code. I’m new in here, may i'll have many questions, lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] infdahai commented on issue #1445: Add support of the `BZMPOP` command
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1554134682
I can accept this task for now. Because I want to implement all commands from [`zset`](https://redis.io/commands/bzmpop/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1584335992
> I‘ve already finish the code, and have tested it manually.
> I'm now trying to add some go tests but i'm not very familiar with go and go test.
> I want to know how to run single test for zset, i tried several ways but it didn't work. :(
Try something like `./x.py test go <build-dir> -run <match-str>`.
And you can refer to `go test --help` for more information about the `-run` option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] infdahai commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1579959585
> I think it's bzpopmax rather than bzmpopmax.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1584329115
I‘ve already finish the code, and have tested it manually.
I'm now trying to add some go tests but i'm not very familiar with go and go test.
I want to know how to run single test for zset, i tried several ways but it didn't work. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk closed issue #1445: Add the support of the `BZMPOP` command
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #1445: Add the support of the `BZMPOP` command
URL: https://github.com/apache/incubator-kvrocks/issues/1445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1564202245
I want to participate in the task, can i contact you through wechat or other ways?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1579945463
I think it's bzpopmax rather than bzmpopmax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1580189787
> Note: As an ASF community, we do not endorse any discussion on some private channels like wechat group.
>
> We prefer public available discussion like GitHub issues, discussions and ASF mailing lists. Feel free to post your questions on these platform.
Ok, i'm just a little shy. I'll post my question if i cannot overcome it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1584335263
> I‘ve already finish the code, and have tested it manually. I'm now trying to add some go tests but i'm not very familiar with go and go test. I want to know how to run single test for zset, i tried several ways but it didn't work. :(
Hi @Yangsx-1, You can reach me on Slack if you need help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1445: Add support of the `BZMPOP` command
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1553897189
@infdahai Would you like to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1580173743
Note: As an ASF community, we does not endorse any discussion on some private channels like wechat group.
We prefer public available discussion like GitHub issues, discussions and ASF mailing lists. Feel free to post your questions on these platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1564239393
Please follow the WeChat Official Account at the bottom of README.md, then join the WeChat group via the guidance.
But we encourage everyone to discuss the proposal or solution via GitHub Discussion instead of a private channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] infdahai commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1564230888
@git-hulk please invite him to wechat groups. Mabye you can search the TimerCB funcs in the codebase to learn how to add the event to the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1445: Add the support of the `BZMPOP` command
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1445:
URL: https://github.com/apache/incubator-kvrocks/issues/1445#issuecomment-1584361307
Ok, I'll try it first. I'll contact you if i have some problems later @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org