You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2011/03/02 16:48:23 UTC

svn commit: r1076265 - /wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java

Author: mgrigorov
Date: Wed Mar  2 15:48:23 2011
New Revision: 1076265

URL: http://svn.apache.org/viewvc?rev=1076265&view=rev
Log:
WICKET-3490 HybridUrlEncoding Strategy throws uncaught NumberFormatException if Integer value space is violated

Return 'null' PageComponentInfo if pageId is not parseable to Integer.


Modified:
    wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java

Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java?rev=1076265&r1=1076264&r2=1076265&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/info/PageComponentInfoTest.java Wed Mar  2 15:48:23 2011
@@ -16,8 +16,6 @@
  */
 package org.apache.wicket.request.mapper.info;
 
-import org.apache.wicket.request.mapper.info.PageComponentInfo;
-
 import junit.framework.TestCase;
 
 /**
@@ -42,13 +40,14 @@ public class PageComponentInfoTest exten
 		assertEquals(pageId, info.getPageInfo().getPageId());
 	}
 
-	private void testPageComponentInfo(PageComponentInfo info, Integer pageId, String listener, String componentPath)
+	private void testPageComponentInfo(PageComponentInfo info, Integer pageId, String listener,
+		String componentPath)
 	{
 		assertNotNull(info.getComponentInfo());
 		assertNotNull(info.getPageInfo());
 
 		assertEquals(pageId, info.getPageInfo().getPageId());
-		
+
 		assertEquals(listener, info.getComponentInfo().getListenerInterface());
 		assertEquals(componentPath, info.getComponentInfo().getComponentPath());
 	}
@@ -63,7 +62,7 @@ public class PageComponentInfoTest exten
 		testPageComponentInfo(info, 2, "click", "foo:bar:baz");
 		assertEquals(s, info.toString());
 	}
-	
+
 	/**
 	 * 
 	 */
@@ -74,4 +73,13 @@ public class PageComponentInfoTest exten
 		testPageInfoOnly(info, 2);
 		assertEquals(s, info.toString());
 	}
+
+	/**
+	 * <a href="https://issues.apache.org/jira/browse/WICKET-3490">WICKET-3490</a>
+	 */
+	public void testParsePageInfo()
+	{
+		PageComponentInfo pageComponentInfo = PageComponentInfo.parse("99999999999999999999999999999999999999999999999999999999999999999999999");
+		assertNull(pageComponentInfo);
+	}
 }