You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jeff Eastman (Commented) (JIRA)" <ji...@apache.org> on 2011/12/26 16:14:30 UTC

[jira] [Commented] (MAHOUT-768) Duplicated DoubleFunction in mahout and mahout-collections (mahout.math package).

    [ https://issues.apache.org/jira/browse/MAHOUT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175947#comment-13175947 ] 

Jeff Eastman commented on MAHOUT-768:
-------------------------------------

Looks like the DoubleFunction interface was moved to collections but remains in math. Can this issue be resolved and closed by 0.6 cutoff?
                
> Duplicated DoubleFunction in mahout and mahout-collections (mahout.math package).
> ---------------------------------------------------------------------------------
>
>                 Key: MAHOUT-768
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-768
>             Project: Mahout
>          Issue Type: Improvement
>          Components: collections, Math
>    Affects Versions: 0.5, collections-1.0
>            Reporter: Dawid Weiss
>            Priority: Minor
>             Fix For: 0.6
>
>
> DoubleFunction is duplicated in Mahout Math and Collections. There are also other things inside m.math.* package that are kept there to avoid circular dependencies... Simply removing DoubleFunction from collections is not going to work because it is needed for compilation (again, circular dependency between collections and math). I see two solutions:
> 1) extract the common definitions inside math.function.* into a separate module. This is a clean solution, but obviously scatters the code even further.
> 2) create a compilation-time, optional dependency on mahout 0.5 in collections, remove the entire mahout.math.* subpackage from collections and live with this. I don't know how Maven handles circular dependencies of this type:
> collections [trunk] -> [optional, required at build time] mahout.math 0.5
> mahout.math [trunk] -> collections [trunk]
> it seems tricky and error-prone, but should also work.
> Looking for other ideas of cleaning this mess up, of course.
> Dawid

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (MAHOUT-768) Duplicated DoubleFunction in mahout and mahout-collections (mahout.math package).

Posted by Ted Dunning <te...@gmail.com>.
Yes.  It conceivably could result in a 1.1 release of collections, but I
kind of doubt it.

On Mon, Dec 26, 2011 at 7:14 AM, Jeff Eastman (Commented) (JIRA) <
jira@apache.org> wrote:

>
>    [
> https://issues.apache.org/jira/browse/MAHOUT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175947#comment-13175947]
>
> Jeff Eastman commented on MAHOUT-768:
> -------------------------------------
>
> Looks like the DoubleFunction interface was moved to collections but
> remains in math. Can this issue be resolved and closed by 0.6 cutoff?
>
> > Duplicated DoubleFunction in mahout and mahout-collections (mahout.math
> package).
> >
> ---------------------------------------------------------------------------------
> >
> >                 Key: MAHOUT-768
> >                 URL: https://issues.apache.org/jira/browse/MAHOUT-768
> >             Project: Mahout
> >          Issue Type: Improvement
> >          Components: collections, Math
> >    Affects Versions: 0.5, collections-1.0
> >            Reporter: Dawid Weiss
> >            Priority: Minor
> >             Fix For: 0.6
> >
> >
> > DoubleFunction is duplicated in Mahout Math and Collections. There are
> also other things inside m.math.* package that are kept there to avoid
> circular dependencies... Simply removing DoubleFunction from collections is
> not going to work because it is needed for compilation (again, circular
> dependency between collections and math). I see two solutions:
> > 1) extract the common definitions inside math.function.* into a separate
> module. This is a clean solution, but obviously scatters the code even
> further.
> > 2) create a compilation-time, optional dependency on mahout 0.5 in
> collections, remove the entire mahout.math.* subpackage from collections
> and live with this. I don't know how Maven handles circular dependencies of
> this type:
> > collections [trunk] -> [optional, required at build time] mahout.math 0.5
> > mahout.math [trunk] -> collections [trunk]
> > it seems tricky and error-prone, but should also work.
> > Looking for other ideas of cleaning this mess up, of course.
> > Dawid
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>