[jira] [Commented] (HADOOP-9443) Port winutils static code analysis change to trunk

["Ivan Mitic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627447#comment-13627447 ] 

Ivan Mitic commented on HADOOP-9443:
------------------------------------

Thanks Chuan for the patch! I diffed with HADOOP-9177 and it looks good, +1

Btw, I think the general recommendation is to reactivate the existing Jira and post a patch compatible with a different branch instead of creating a new Jira. This makes it transparent to the reviewer/committer that the code has already been reviewed.
                
> Port winutils static code analysis change to trunk
> --------------------------------------------------
>
>                 Key: HADOOP-9443
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9443
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>         Attachments: HADOOP-9443-trunk.patch
>
>
> We hit a problem in winutils when running tests on Windows. The static code analysis change will fix the problem. More specifically, the old code always assumes the security descriptor get from GetSecurityDescriptorControl() is relative, and will make an absolute security descriptor out of it. The new absolute security descriptor will then pass to SetSecurityDescriptorDacl() to set permissions on the file. If the security descriptor is absolute, the new absolute security descriptor will be NULL, and we will run into the problem. This is what happened exactly in our case. The fix from static code analysis will solve the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira