You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2024/06/07 08:40:28 UTC
[PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Jibing-Li opened a new pull request, #36046:
URL: https://github.com/apache/doris/pull/36046
After drop stats when partition analyze function enabled. Auto collector will collect the dropped table twice. Because int the first time analyzing, it doesn't write the partition update rows record to tableStats. In this case, the collector will consider the table has not collect partition level stats, which will trigger the second time collection. This pr is to fix this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li merged PR #36046:
URL: https://github.com/apache/doris/pull/36046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154391151
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154375852
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154437465
<details>
<summary>TPC-DS: <b>Total hot run time: 172600 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 685934eb3d7d77bc6a658e0ae6de19f01dc2ebf2, data reload: false
query1 921 372 373 372
query2 6458 2364 2268 2268
query3 6645 204 205 204
query4 19891 17510 17483 17483
query5 4134 478 466 466
query6 244 157 160 157
query7 4581 287 286 286
query8 326 295 297 295
query9 8483 2405 2392 2392
query10 615 296 291 291
query11 11188 10546 10694 10546
query12 130 87 88 87
query13 1621 358 360 358
query14 9799 6645 7501 6645
query15 238 187 186 186
query16 7759 260 256 256
query17 1909 540 539 539
query18 1944 266 265 265
query19 193 155 156 155
query20 96 80 79 79
query21 210 128 121 121
query22 4417 4202 4107 4107
query23 33467 32864 32997 32864
query24 11901 2861 2893 2861
query25 700 349 363 349
query26 1824 152 152 152
query27 2950 303 313 303
query28 7698 2023 2017 2017
query29 1089 613 589 589
query30 272 149 147 147
query31 950 727 729 727
query32 92 55 54 54
query33 758 292 298 292
query34 939 467 451 451
query35 714 596 613 596
query36 1094 927 932 927
query37 176 68 69 68
query38 2847 2715 2700 2700
query39 844 785 790 785
query40 284 123 122 122
query41 55 51 50 50
query42 119 100 101 100
query43 572 541 542 541
query44 1264 725 733 725
query45 201 167 169 167
query46 1083 693 698 693
query47 1854 1769 1806 1769
query48 378 289 297 289
query49 1169 395 391 391
query50 763 391 386 386
query51 6727 6661 6665 6661
query52 113 91 93 91
query53 366 285 284 284
query54 936 437 435 435
query55 75 70 71 70
query56 267 247 258 247
query57 1157 1055 1062 1055
query58 250 227 240 227
query59 3447 3232 3106 3106
query60 284 264 263 263
query61 90 88 88 88
query62 656 448 461 448
query63 331 284 292 284
query64 9862 2195 1715 1715
query65 3142 3120 3093 3093
query66 1376 333 353 333
query67 15615 15213 14805 14805
query68 4649 547 534 534
query69 523 422 392 392
query70 1202 1142 1141 1141
query71 390 278 268 268
query72 7257 5490 5540 5490
query73 746 318 322 318
query74 5851 5436 5463 5436
query75 3434 2710 2647 2647
query76 2735 942 939 939
query77 483 289 286 286
query78 10176 9982 9822 9822
query79 2032 509 512 509
query80 1352 457 446 446
query81 567 217 221 217
query82 776 101 105 101
query83 196 169 169 169
query84 268 83 94 83
query85 1367 274 269 269
query86 468 297 309 297
query87 3295 3094 3067 3067
query88 3989 2395 2310 2310
query89 478 386 381 381
query90 1865 191 188 188
query91 122 99 95 95
query92 62 49 49 49
query93 2161 527 508 508
query94 1174 178 182 178
query95 397 301 307 301
query96 596 264 272 264
query97 3163 3044 2995 2995
query98 220 193 194 193
query99 1344 851 829 829
Total cold run time: 275891 ms
Total hot run time: 172600 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154447263
<details>
<summary>ClickBench: <b>Total hot run time: 31 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 685934eb3d7d77bc6a658e0ae6de19f01dc2ebf2, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.03 0.03
query3 0.23 0.06 0.05
query4 1.68 0.07 0.07
query5 0.53 0.48 0.53
query6 1.13 0.72 0.72
query7 0.02 0.01 0.01
query8 0.06 0.04 0.05
query9 0.54 0.49 0.48
query10 0.54 0.56 0.54
query11 0.15 0.12 0.12
query12 0.15 0.12 0.11
query13 0.59 0.59 0.60
query14 0.77 0.76 0.79
query15 0.83 0.82 0.81
query16 0.37 0.36 0.37
query17 1.00 1.03 0.95
query18 0.21 0.25 0.24
query19 1.82 1.71 1.83
query20 0.01 0.01 0.01
query21 15.41 0.65 0.66
query22 4.30 7.18 2.49
query23 18.34 1.26 1.22
query24 2.13 0.23 0.21
query25 0.17 0.08 0.09
query26 0.27 0.18 0.18
query27 0.09 0.08 0.07
query28 13.21 1.00 0.99
query29 12.65 3.26 3.25
query30 0.26 0.07 0.06
query31 2.87 0.38 0.39
query32 3.29 0.47 0.47
query33 2.84 2.90 2.92
query34 17.01 4.48 4.42
query35 4.46 4.46 4.49
query36 0.64 0.48 0.48
query37 0.18 0.15 0.15
query38 0.14 0.14 0.14
query39 0.04 0.03 0.03
query40 0.18 0.14 0.14
query41 0.09 0.05 0.05
query42 0.06 0.05 0.04
query43 0.04 0.03 0.04
Total cold run time: 109.42 s
Total hot run time: 31 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154371511
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154391074
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](statistics)Fix analyze twice after drop stats bug. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36046:
URL: https://github.com/apache/doris/pull/36046#issuecomment-2154415176
<details>
<summary>TPC-H: <b>Total hot run time: 40013 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 685934eb3d7d77bc6a658e0ae6de19f01dc2ebf2, data reload: false
------ Round 1 ----------------------------------
q1 18356 4490 4415 4415
q2 2563 200 187 187
q3 11200 1115 1158 1115
q4 10696 790 914 790
q5 7649 2695 2705 2695
q6 224 142 138 138
q7 970 610 621 610
q8 9377 2074 2095 2074
q9 8921 6494 6481 6481
q10 8938 3684 3678 3678
q11 446 239 245 239
q12 398 239 228 228
q13 17762 2966 2965 2965
q14 260 224 222 222
q15 519 469 467 467
q16 492 369 366 366
q17 960 659 683 659
q18 8101 7436 7359 7359
q19 4820 1508 1465 1465
q20 657 311 318 311
q21 4864 3212 3923 3212
q22 390 341 337 337
Total cold run time: 118563 ms
Total hot run time: 40013 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4361 4302 4243 4243
q2 372 272 261 261
q3 2988 2715 2722 2715
q4 1882 1592 1631 1592
q5 5227 5249 5239 5239
q6 222 129 129 129
q7 2033 1752 1756 1752
q8 3202 3304 3284 3284
q9 8289 8271 8350 8271
q10 3851 3627 3631 3627
q11 601 493 494 493
q12 776 605 591 591
q13 16335 2972 3006 2972
q14 288 273 278 273
q15 509 496 478 478
q16 465 432 412 412
q17 1779 1497 1453 1453
q18 7607 7687 7338 7338
q19 2290 1552 1524 1524
q20 1982 1793 1749 1749
q21 4802 4594 4762 4594
q22 613 530 563 530
Total cold run time: 70474 ms
Total hot run time: 53520 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org