[jira] Commented: (WICKET-3377) newPageMap at Session delete the default pageMap when excess Pagemap, and unneded pageMap are created for popupSettings with window name.

["Pedro Santos (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987660#action_12987660 ] 

Pedro Santos commented on WICKET-3377:
--------------------------------------

Hi Yaron, currently the page map is removed from session respecting the least recently used sequence. Default page map can be removed from it and recreated later when responding an request, I see no problem here.

> newPageMap at Session delete the default pageMap when excess Pagemap, and unneded pageMap are created for popupSettings with window name.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3377
>                 URL: https://issues.apache.org/jira/browse/WICKET-3377
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15
>            Reporter: Yaron
>            Priority: Critical
>
> Related to: Session causing memory leak after WICKET-3108
> When excess Pagemaps are reached then it might delete the default page map.
> It seems unwise to delete the default page map as it usualy will live longer then page maps that will be created after it.
> Seting a window name for PopupSettings will set it a page map name, this will create a pageMap at link creation.
> It is not clear why the link target get the name using the pageMap (This create the page map) and not use the window name from the popup setting directly:
> Code from Link class:
> 			if (popupSettings != null)
> 			{
> 				IPageMap popupPageMap = popupSettings.getPageMap(this);
> 				if (popupPageMap != null && popupPageMap.getName() != null)
> 				{
> 					tag.put("target", popupPageMap.getName());
> 				}
> 			}
> We have a table with links at the columns that each link needs a diffrent window name, the number of rows in the table changes and could reach 500.
> This now mean the page than containes the table with the link will lose its page map.
> It is needed to keep the default page map, and to create the page map for a popup link at link activation and not link creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.