You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "RustedBones (via GitHub)" <gi...@apache.org> on 2023/03/03 14:18:42 UTC

[GitHub] [beam] RustedBones opened a new pull request, #25713: Set hamcrest and junit as provided for google-cloud-platform java sdk

RustedBones opened a new pull request, #25713:
URL: https://github.com/apache/beam/pull/25713

   The `beam-sdks-java-io-google-cloud-platform` java library is pulling unwanted transitive test dependencies
   - junit
   - hamcrest
   
   Mark those `provided` (as also done in the java direct runner)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25713: Move beam-sdks-java-io-google-cloud-platform test implementations to test scope

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #25713:
URL: https://github.com/apache/beam/pull/25713#issuecomment-1494213162

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label java.
   R: @pabloem for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] RustedBones commented on a diff in pull request #25713: Move beam-sdks-java-io-google-cloud-platform test implementations to test scope

Posted by "RustedBones (via GitHub)" <gi...@apache.org>.

RustedBones commented on code in PR #25713:
URL: https://github.com/apache/beam/pull/25713#discussion_r1144591180


##########
runners/google-cloud-dataflow-java/examples-streaming/build.gradle:
##########
@@ -47,6 +47,9 @@ task windmillPreCommit(type: Test) {
      "--tempRoot=${gcsTempRoot}",
      "--runner=TestDataflowRunner",
      "--dataflowWorkerJar=${dataflowWorkerJar}",
+     // Provide job with a customizable worker jar.
+     // With legacy worker jar, containerImage is set to empty (i.e. to use the internal build).
+     // More context and discussions can be found in PR#6694.

Review Comment:
   @Abacn I think this is the root cause of the issue.
   By setting `workerHarnessContainerImage` to an empty string, we instruct to pick up the non-versioned image as explained in https://github.com/apache/beam/pull/6694. It looks like this image ignores the java version, and runs with java 8.
   
   @lukecwik can you help on how to select the proper container here ?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org