You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/17 16:20:25 UTC
[GitHub] [incubator-devlake] keon94 opened a new issue, #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
keon94 opened a new issue, #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305
## What and why to refactor
We have many spots in our Golang code where we simply panic with an error for no obvious reason. Panicking in general should be reserved only for when error handling is not an option.
## Describe the solution you'd like
Go over these [search results](https://github.com/apache/incubator-devlake/search?l=Go&q=panic%28) and identify the places where a panic could be replaced with a simple error return.
## Related issues
n/a
## Additional context
n/a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] shubham-cmyk commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "shubham-cmyk (via GitHub)" <gi...@apache.org>.
shubham-cmyk commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1594435632
You must remove the panic and make it simple return.
@Palanikannan1437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1270582276
@hezyin Could you assign this to @shubham-cmyk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1316072420
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Palanikannan1437 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "Palanikannan1437 (via GitHub)" <gi...@apache.org>.
Palanikannan1437 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1598082022
> You must remove the panic and make it simple return.
@keon94 is that all or there's more to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1504315527
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Refactor][Backend] Re-evaluate Golang "panic" logic [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1765461492
This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1397722254
@Palanikannan1437 Sure! Happy coding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Palanikannan1437 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "Palanikannan1437 (via GitHub)" <gi...@apache.org>.
Palanikannan1437 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1605632677
Sure, thanks @keon94 and @shubham-cmyk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Dev79844 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "Dev79844 (via GitHub)" <gi...@apache.org>.
Dev79844 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1598067258
Hey @shubham-cmyk! Can I work on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Palanikannan1437 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
Palanikannan1437 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1396560441
Hey @keon94, I'd love to work on this issue after I'm done with the Gitpod PR, could you please assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1454292316
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1454331367
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1598091096
Yes, remove panics and return errors.Error where possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
URL: https://github.com/apache/incubator-devlake/issues/3305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Palanikannan1437 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "Palanikannan1437 (via GitHub)" <gi...@apache.org>.
Palanikannan1437 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1592431277
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] shubham-cmyk commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "shubham-cmyk (via GitHub)" <gi...@apache.org>.
shubham-cmyk commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1592762999
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1306409729
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1496756534
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
URL: https://github.com/apache/incubator-devlake/issues/3305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Palanikannan1437 commented on issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
Posted by "Palanikannan1437 (via GitHub)" <gi...@apache.org>.
Palanikannan1437 commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1594207344
Hey @keon94, could you please give a brief overview of how you'd like the errors to be handled according to different scenarios?
I understand "it depends", but what would you prefer over the panic, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Refactor][Backend] Re-evaluate Golang "panic" logic [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3305:
URL: https://github.com/apache/incubator-devlake/issues/3305#issuecomment-1751873316
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Refactor][Backend] Re-evaluate Golang "panic" logic [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3305: [Refactor][Backend] Re-evaluate Golang "panic" logic
URL: https://github.com/apache/incubator-devlake/issues/3305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org