You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by bh...@apache.org on 2021/10/15 17:20:48 UTC

[samza] branch master updated: Using TCK Tested JDK builds of OpenJDK (#1545)

This is an automated email from the ASF dual-hosted git repository.

bharathkk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git


The following commit(s) were added to refs/heads/master by this push:
     new 96d4b80  Using TCK Tested JDK builds of OpenJDK (#1545)
96d4b80 is described below

commit 96d4b80caf1fcdfdd1f751a4cd33a3f4b5739c0b
Author: Carl Dea <ca...@gmail.com>
AuthorDate: Fri Oct 15 13:20:42 2021 -0400

    Using TCK Tested JDK builds of OpenJDK (#1545)
    
    The AdoptOpenJDK has been discontinued since July 2021 (https://adoptopenjdk.net). Switching the distribution to Azul Zulu. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK.
    
    Also added is a fixed (major) release version(s) such as `JDK 8.0.192`. This is often a good practice whenever a build/test triggers (push/pull events) to help determine if the latest (`JDK 8`) had failed the from the **latest build** vs something in **your code** caused (or introduced).
    
    **For example**, when building with `JDK 8.0.192` (fixed version) the build/tests passes (Green) and JDK 8 fails (Red) will mean that the latest `JDK 8` was the cause and not your code.
    
    **Note:** Other distributions such as Temurin do not support archived fixed releases prior to Sept. 2021 and many non LTS (long term support) releases if you plan to try out newer features in the language.
---
 .github/workflows/ci.yml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 365ea65..3d18c3e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -23,7 +23,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     timeout-minutes: 60
-
+    strategy:
+      matrix:
+        java-version: [ 8.0.192, 8 ]
     steps:
       - name: Cache Gradle packages
         uses: actions/cache@v2
@@ -35,11 +37,11 @@ jobs:
 
       - uses: actions/checkout@v2
 
-      - name: Set up JDK 8
+      - name: Set up JDK ${{ matrix.java-version }}
         uses: actions/setup-java@v2
         with:
-          java-version: '8'
-          distribution: 'adopt'
+          java-version: ${{ matrix.java-version }}
+          distribution: 'zulu'
 
       - name: Validate Gradle wrapper
         uses: gradle/wrapper-validation-action@v1