[GitHub] [spark] LuciferYang commented on a change in pull request #31865: [SPARK-34774][BUILD] Ensure change-scala-version.sh update scala.version in parent POM correctly

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #31865:
URL: https://github.com/apache/spark/pull/31865#discussion_r595799263



##########
File path: pom.xml
##########
@@ -3300,6 +3300,13 @@
 
     <profile>
       <id>scala-2.12</id>
+      <properties>
+        <!-- 
+         SPARK-34774 Add this property to ensure change-scala-version.sh can replace the public `scala.version`
+         property correctly. 
+        -->
+        <scala.version>2.12.10</scala.version>

Review comment:
       This change will produce two`< scala.version >2.12.10</ scala.version >`, Should we extract a common property like `< scala.default.version >2.12.10</scala.default.version >` and reference it here as `<scala.version>${scala.default.version}</scala.version>` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org