You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2014/09/10 20:53:34 UTC
Re: svn commit: r1624094 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
romain, the key is enough. the ID given to addAnnotatedType must NOT get changed.
A user can use this key to identify his own SyntheticAnnoatedTypes later...
LieGrue,
strub
On Wednesday, 10 September 2014, 20:46, "rmannibucau@apache.org" <rm...@apache.org> wrote:
>
>
>Author: rmannibucau
>Date: Wed Sep 10 18:45:38 2014
>New Revision: 1624094
>
>URL: http://svn.apache.org/r1624094
>Log:
>id are better when unique ;), todo: surely remove AnnotatedElementFactory.OWB_DEFAULT_KEY, and surely use same algo as in toString of OwbBeans (keeping extension class in the id)
>
>Modified:
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>
>Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1624094&r1=1624093&r2=1624094&view=diff
>==============================================================================
>--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (original)
>+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java Wed Sep 10 18:45:38 2014
>@@ -1223,7 +1223,7 @@ public class BeanManagerImpl implements
>
> public void addAdditionalAnnotatedType(Object extension, AnnotatedType<?> annotatedType)
> {
>- addAdditionalAnnotatedType(extension, annotatedType, extension + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>+ addAdditionalAnnotatedType(extension, annotatedType, extension.toString() + annotatedType + AnnotatedElementFactory.OWB_DEFAULT_KEY);
> }
>
> public <T> void addAdditionalAnnotatedType(Object extension, AnnotatedType<T> inAnnotatedType, String id)
>
>
>
>
>
Re: svn commit: r1624094 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
Posted by Romain Manni-Bucau <rm...@gmail.com>.
dont get your comment, this is not this method, this one is the
default one (void addAnnotatedType(AnnotatedType<?> type))
By tck this one can't reuse default key
the value is just a unique generated one. We should enhance for sure
but technically it seems ok
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-09-10 20:53 GMT+02:00 Mark Struberg <st...@yahoo.de>:
> romain, the key is enough. the ID given to addAnnotatedType must NOT get changed.
>
> A user can use this key to identify his own SyntheticAnnoatedTypes later...
>
> LieGrue,
> strub
>
>
>
> On Wednesday, 10 September 2014, 20:46, "rmannibucau@apache.org" <rm...@apache.org> wrote:
>
>
>>
>>
>>Author: rmannibucau
>>Date: Wed Sep 10 18:45:38 2014
>>New Revision: 1624094
>>
>>URL: http://svn.apache.org/r1624094
>>Log:
>>id are better when unique ;), todo: surely remove AnnotatedElementFactory.OWB_DEFAULT_KEY, and surely use same algo as in toString of OwbBeans (keeping extension class in the id)
>>
>>Modified:
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>
>>Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1624094&r1=1624093&r2=1624094&view=diff
>>==============================================================================
>>--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (original)
>>+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java Wed Sep 10 18:45:38 2014
>>@@ -1223,7 +1223,7 @@ public class BeanManagerImpl implements
>>
>> public void addAdditionalAnnotatedType(Object extension, AnnotatedType<?> annotatedType)
>> {
>>- addAdditionalAnnotatedType(extension, annotatedType, extension + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>>+ addAdditionalAnnotatedType(extension, annotatedType, extension.toString() + annotatedType + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>> }
>>
>> public <T> void addAdditionalAnnotatedType(Object extension, AnnotatedType<T> inAnnotatedType, String id)
>>
>>
>>
>>
>>
Re: svn commit: r1624094 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
Posted by Romain Manni-Bucau <rm...@gmail.com>.
dont get your comment, this is not this method, this one is the
default one (void addAnnotatedType(AnnotatedType<?> type))
By tck this one can't reuse default key
the value is just a unique generated one. We should enhance for sure
but technically it seems ok
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-09-10 20:53 GMT+02:00 Mark Struberg <st...@yahoo.de>:
> romain, the key is enough. the ID given to addAnnotatedType must NOT get changed.
>
> A user can use this key to identify his own SyntheticAnnoatedTypes later...
>
> LieGrue,
> strub
>
>
>
> On Wednesday, 10 September 2014, 20:46, "rmannibucau@apache.org" <rm...@apache.org> wrote:
>
>
>>
>>
>>Author: rmannibucau
>>Date: Wed Sep 10 18:45:38 2014
>>New Revision: 1624094
>>
>>URL: http://svn.apache.org/r1624094
>>Log:
>>id are better when unique ;), todo: surely remove AnnotatedElementFactory.OWB_DEFAULT_KEY, and surely use same algo as in toString of OwbBeans (keeping extension class in the id)
>>
>>Modified:
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>
>>Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1624094&r1=1624093&r2=1624094&view=diff
>>==============================================================================
>>--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (original)
>>+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java Wed Sep 10 18:45:38 2014
>>@@ -1223,7 +1223,7 @@ public class BeanManagerImpl implements
>>
>> public void addAdditionalAnnotatedType(Object extension, AnnotatedType<?> annotatedType)
>> {
>>- addAdditionalAnnotatedType(extension, annotatedType, extension + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>>+ addAdditionalAnnotatedType(extension, annotatedType, extension.toString() + annotatedType + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>> }
>>
>> public <T> void addAdditionalAnnotatedType(Object extension, AnnotatedType<T> inAnnotatedType, String id)
>>
>>
>>
>>
>>