[GitHub] [pulsar] eolivelli commented on a diff in pull request #16898: [fix][function-worker] Fix load trust certificate

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #16898:
URL: https://github.com/apache/pulsar/pull/16898#discussion_r956560882


##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java:
##########
@@ -283,15 +283,15 @@ public static PulsarClient getPulsarClient(String pulsarServiceUrl) {
     }
 
     public static PulsarClient getPulsarClient(String pulsarServiceUrl, String authPlugin, String authParams,
-                                               Boolean useTls, String tlsTrustCertsFilePath,
+                                               Boolean useTls /* Deprecated */, String tlsTrustCertsFilePath,

Review Comment:
   You should remove the parameter if it is not used anymore.
   Otherwise the caller may think that it is applied



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org