You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/20 11:54:19 UTC

[GitHub] [ratis] ChenSammi opened a new pull request, #686: RATIS-1629. Fix flaky TestRaftReconfigurationWithSimulatedRpc#testKillLeaderDuringReconf

ChenSammi opened a new pull request, #686:
URL: https://github.com/apache/ratis/pull/686

   https://issues.apache.org/jira/browse/RATIS-1629
   
   This testKillLeaderDuringReconf fail randomly at the check 
   RaftReconfigurationBaseTest.runTestKillLeaderDuringReconf -> RaftServerTestUtil#waitAndCheckNewConf#Assert.assertFalse(conf.containsInConf(server.getId()));
   
   The test tries to move a cluster from
    [s0(L), s1, s2]  to 
    [s0(killed), s1(removed), s2, s3(new)]. 
   
   There is chance that s3 cannot join the group because of timing. s3 is rejected and shutdown itself when it receives an shutdown command from the new Leader which isn't in the configuration transitional state. 
   
   If s3 cannot join the group, the "Assert.assertFalse(conf.containsInConf(server.getId()))" will fail because the set configuration request will mot get majority responses. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] drriguz commented on pull request #686: RATIS-1629. Fix flaky TestRaftReconfigurationWithSimulatedRpc#testKillLeaderDuringReconf

Posted by GitBox <gi...@apache.org>.
drriguz commented on PR #686:
URL: https://github.com/apache/ratis/pull/686#issuecomment-1190467213

   It might be better to retry the test instead of skipping it, I've make another pull request for fixing this, please review it. See https://github.com/apache/ratis/pull/687


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo merged pull request #686: RATIS-1629. Fix flaky TestRaftReconfigurationWithSimulatedRpc#testKillLeaderDuringReconf

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #686:
URL: https://github.com/apache/ratis/pull/686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org