You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/16 18:26:02 UTC
[GitHub] [tvm] junrushao1994 opened a new pull request #9756: [MetaScheduler] Add the missing `HasWorkload` interface to the Database
junrushao1994 opened a new pull request #9756:
URL: https://github.com/apache/tvm/pull/9756
This PR add a previously missing interface `HasWorkload` to the database interface.
CC: @yzhliu @Laurawly @FrozenGene
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9756: [MetaSchedule] Add the missing `HasWorkload` interface to the Database
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9756:
URL: https://github.com/apache/tvm/pull/9756#discussion_r771105937
##########
File path: tests/python/unittest/test_meta_schedule_task_scheduler.py
##########
@@ -140,6 +140,9 @@ def __init__(self):
self.records = []
self.workload_reg = []
+ def has_workload(self, mod: IRModule) -> bool:
+ return False
Review comment:
Aha this is a dummy database for mock testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on pull request #9756: [MetaSchedule] Add the missing `HasWorkload` interface to the Database
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #9756:
URL: https://github.com/apache/tvm/pull/9756#issuecomment-996466371
Merged now. @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9756: [MetaSchedule] Add the missing `HasWorkload` interface to the Database
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9756:
URL: https://github.com/apache/tvm/pull/9756#issuecomment-996470742
Thank you so much for your time!! @FrozenGene
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene merged pull request #9756: [MetaSchedule] Add the missing `HasWorkload` interface to the Database
Posted by GitBox <gi...@apache.org>.
FrozenGene merged pull request #9756:
URL: https://github.com/apache/tvm/pull/9756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on a change in pull request #9756: [MetaSchedule] Add the missing `HasWorkload` interface to the Database
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on a change in pull request #9756:
URL: https://github.com/apache/tvm/pull/9756#discussion_r771103101
##########
File path: tests/python/unittest/test_meta_schedule_task_scheduler.py
##########
@@ -140,6 +140,9 @@ def __init__(self):
self.records = []
self.workload_reg = []
+ def has_workload(self, mod: IRModule) -> bool:
+ return False
Review comment:
Should we query `workload_reg` here instead of `return False` simply?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org