[GitHub] [iceberg] Fokko commented on pull request #6348: Python: Update license-checker

[GitBox <gi...@apache.org>]

Fokko commented on PR #6348:
URL: https://github.com/apache/iceberg/pull/6348#issuecomment-1368832789

   @rdblue I missed your comment here. The one is exactly the same as the Java one:
   ```
   ➜  iceberg git:(fd-copy-rat-from-iceberg) diff dev/check-license python/dev/check-license
   43c43
   <   if [ $? -ne 0 ]; then 
   ---
   >   if [ $? -ne 0 ]; then
   80c80
   < if test ! -z "$ERRORS"; then 
   ---
   > if test ! -z "$ERRORS"; then
   84c84
   < else 
   ---
   > else
   ```
   
   The difference is in the trailing whitespace on the Java one. By re-using I was under the impression that we don't want to have two identical scripts in the repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org