[jira] [Comment Edited] (REEF-552) Remove Wake classes and methods with short deprecation-chains since 0.11

["Brian Cho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651522#comment-14651522 ] 

Brian Cho edited comment on REEF-552 at 8/3/15 6:57 AM:
--------------------------------------------------------

I've added a PR at https://github.com/apache/incubator-reef/pull/330

Our policy is to remove only methods that have been marked {{@Deprecated}} since 0.11. However, removing a deprecated method is not always safe -- as a consequence non-deprecated methods end up being unable to compile after removal.

We have to make some judgement calls, or else we'll end up not removing anything for this release. I've marked the three cases I ran into in the PR with a {{// TODO: [REEF-552]}}. What are your thoughts on cutting corners and removing these parts?

>From glancing at the code, future PRs will likely require (_a lot_) more judgement calls.


was (Author: chobrian):
I've added a PR at https://github.com/apache/incubator-reef/pull/330

Our policy is to remove only methods that have been marked {{@Deprecated}} since 0.11. However, removing a deprecated method is not always safe -- non-deprecated methods end up being unable not compile after removal. (In fact, almost none of the deprecated methods are strictly safe.)

We have to make some judgement calls, or else we'll end up not removing anything for this release. I've marked the three cases I ran into in the PR with a {{// TODO: [REEF-552]}}. What are your thoughts on cutting corners and removing these parts?

>From glancing at the code, future PRs will likely recall (a lot) more judgement.

> Remove Wake classes and methods with short deprecation-chains since 0.11
> ------------------------------------------------------------------------
>
>                 Key: REEF-552
>                 URL: https://issues.apache.org/jira/browse/REEF-552
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Wake
>            Reporter: Brian Cho
>             Fix For: 0.12
>
>
> This is in partial fulfillment of REEF-547. Will first try to remove deprecated classes and methods that have relatively short deprecation-chains.
> After identifying a few "root" deprecation elements, other deprecated dependent elements are removed recursively. The root elements identified are:
> - class {{NetUtils}}
> - class {{LocalAddressProviderFactory}}
> - constructor {{MessagingTransportFactory()}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)