You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/08/28 19:52:05 UTC
incubator-reef git commit: [REEF-606] Generalize IPartitionedDataset
Repository: incubator-reef
Updated Branches:
refs/heads/master 8c494adf9 -> b89ca82f2
[REEF-606] Generalize IPartitionedDataset
This addressed the issue by
* Making interface IPartition generic
* Open function is renamed to GetPartitionHandle and return a generic
type.
JIRA:
[REEF-606](https://issues.apache.org/jira/browse/REEF-606)
Pull Request:
This closes #425
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/b89ca82f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/b89ca82f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/b89ca82f
Branch: refs/heads/master
Commit: b89ca82f2856505595a69ad72351c7824d4ab46a
Parents: 8c494ad
Author: Dhruv <dh...@gmail.com>
Authored: Wed Aug 26 22:50:00 2015 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Fri Aug 28 10:43:05 2015 -0700
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs | 5 +++--
lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs | 10 ++++++----
.../PartitionedData/Random/RandomPartition.cs | 4 ++--
.../PartitionedData/Random/RandomPartitionDescriptor.cs | 3 ++-
4 files changed, 13 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b89ca82f/lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs b/lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs
index bf5e85a..13813ba 100644
--- a/lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs
+++ b/lang/cs/Org.Apache.REEF.IO.Tests/TestRandomDataSet.cs
@@ -17,6 +17,7 @@
* under the License.
*/
+using System.IO;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Org.Apache.REEF.IO.PartitionedData;
using Org.Apache.REEF.IO.PartitionedData.Random;
@@ -79,11 +80,11 @@ namespace Org.Apache.REEF.IO.Tests
var partition =
TangFactory.GetTang()
.NewInjector(partitionDescriptor.GetPartitionConfiguration())
- .GetInstance<IPartition>();
+ .GetInstance<IPartition<Stream>>();
Assert.IsNotNull(partition);
Assert.IsNotNull(partition.Id);
- using (var partitionStream = partition.Open())
+ using (var partitionStream = partition.GetPartitionHandle())
{
Assert.IsNotNull(partitionStream);
Assert.IsTrue(partitionStream.CanRead);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b89ca82f/lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs b/lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs
index 73f422f..c0e6799 100644
--- a/lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs
+++ b/lang/cs/Org.Apache.REEF.IO/PartitionedData/IPartition.cs
@@ -24,7 +24,9 @@ namespace Org.Apache.REEF.IO.PartitionedData
/// <summary>
/// Evaluator-Side representation of a data set partition.
/// </summary>
- public interface IPartition
+ /// <typeparam name="T">Generic Type representing data pointer.
+ /// For example, for data in local file it can be file pointer </typeparam>
+ public interface IPartition<T>
{
/// <summary>
/// The id of the partition.
@@ -32,9 +34,9 @@ namespace Org.Apache.REEF.IO.PartitionedData
string Id { get; }
/// <summary>
- /// Opens the stream to the underlying partition.
+ /// Gives a pointer to the underlying partition.
/// </summary>
- /// <returns>A read-only stream.</returns>
- Stream Open();
+ /// <returns>The pointer to the underlying partition</returns>
+ T GetPartitionHandle();
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b89ca82f/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartition.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartition.cs b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartition.cs
index 03c6035..4b427f3 100644
--- a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartition.cs
+++ b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartition.cs
@@ -28,7 +28,7 @@ namespace Org.Apache.REEF.IO.PartitionedData.Random
/// <summary>
/// An implementation of IPartition that returns a configurable number of random doubles.
/// </summary>
- internal sealed class RandomPartition : IPartition
+ internal sealed class RandomPartition : IPartition<Stream>
{
private readonly string _id;
private readonly byte[] _randomData;
@@ -60,7 +60,7 @@ namespace Org.Apache.REEF.IO.PartitionedData.Random
get { return _id; }
}
- public Stream Open()
+ public Stream GetPartitionHandle()
{
return new MemoryStream(_randomData, false);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b89ca82f/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartitionDescriptor.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartitionDescriptor.cs b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartitionDescriptor.cs
index 9b37f21..830291b 100644
--- a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartitionDescriptor.cs
+++ b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomPartitionDescriptor.cs
@@ -17,6 +17,7 @@
* under the License.
*/
+using System.IO;
using Org.Apache.REEF.IO.PartitionedData.Random.Parameters;
using Org.Apache.REEF.Tang.Implementations.Tang;
using Org.Apache.REEF.Tang.Interface;
@@ -42,7 +43,7 @@ namespace Org.Apache.REEF.IO.PartitionedData.Random
public IConfiguration GetPartitionConfiguration()
{
return TangFactory.GetTang().NewConfigurationBuilder()
- .BindImplementation(typeof(IPartition), typeof(RandomPartition))
+ .BindImplementation(typeof(IPartition<Stream>), typeof(RandomPartition))
.BindNamedParameter(typeof(PartitionId), _id)
.BindNamedParameter(typeof(NumberOfDoublesPerPartition), _numberOfDoubles.ToString())
.Build();