You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:14:36 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

rkhachatryan commented on a change in pull request #12244:
URL: https://github.com/apache/flink/pull/12244#discussion_r428043879



##########
File path: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
##########
@@ -300,7 +300,8 @@ public void testCheckpointingCustomKvStateJobWithCustomClassLoader() throws IOEx
 	 */
 	@Test
 	public void testDisposeSavepointWithCustomKvState() throws Exception {
-		ClusterClient<?> clusterClient = new MiniClusterClient(new Configuration(), miniClusterResource.getMiniCluster());
+		Configuration configuration = new Configuration();

Review comment:
       nit: I guess it was extracted to disable unaligned checkpoints, but then CLI argument was used; so this variable can be inlined back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org