You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2007/09/30 14:26:50 UTC

[jira] Created: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
------------------------------------------------------------------------------------------

                 Key: HADOOP-1972
                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
             Project: Hadoop
          Issue Type: Bug
          Components: mapred
    Affects Versions: 0.14.1
            Reporter: Arun C Murthy
            Assignee: Arun C Murthy
            Priority: Blocker
             Fix For: 0.14.2


{{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.

The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531692 ] 

Devaraj Das commented on HADOOP-1972:
-------------------------------------

+1

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1972:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Arun.

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531329 ] 

Hadoop QA commented on HADOOP-1972:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12366818/HADOOP-1972_1_20070930.patch
against trunk revision r580487.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/852/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/852/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/852/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/852/console

This message is automatically generated.

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531944 ] 

Hudson commented on HADOOP-1972:
--------------------------------

Integrated in Hadoop-Nightly #258 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/258/])

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-1972:
----------------------------------

    Status: Patch Available  (was: Open)

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1972) LzoCompressor.finished doesn't check whether the user actually wants to finish compressing

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-1972:
----------------------------------

    Attachment: HADOOP-1972_1_20070930.patch

Straight-forward fix.

> LzoCompressor.finished doesn't check whether the user actually wants to finish compressing
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1972
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.14.1
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.14.2
>
>         Attachments: HADOOP-1972_1_20070930.patch
>
>
> {{LzoCompressor.finished}} needs to check the *finish* variable, set when the user wants to finish compression and flush compressed data to the underlying stream.
> The problem with this is that the user cannot chain writes to BlockCompressorStream without resetting all the time...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.