You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2015/05/02 05:18:02 UTC
Review Request 33773: Aurora-1302: Allow rc script to set an explicit
version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33773/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: Aurora-1302
https://issues.apache.org/jira/browse/Aurora-1302
Repository: aurora
Description
-------
Adds ability to override current .auroraversion when making an release candidate.
Updating CHANGELOG for 0.8.0 release.
Updating .auroraversion to 0.8.0-rc0.
Diffs
-----
build-support/release/release-candidate 14dbeddac663733b23383643dad91db0abe8b9f7
Diff: https://reviews.apache.org/r/33773/diff/
Testing
-------
./build-support/release/release-candidate -l m -r 0 -v 0.8.0
Performing dry-run
Generating changelog
[master 234be4e] Updating CHANGELOG for 0.8.0 release.
1 file changed, 17 insertions(+)
Creating 0.8.0-rc0 branch
Committing updated .auroraversion on master
[master eb6b505] Incrementing snapshot version to 0.9.0-SNAPSHOT.
1 file changed, 1 insertion(+), 1 deletion(-)
Checking out 0.8.0-rc0 branch and updating .auroraversion
Switched to branch '0.8.0-rc0'
[0.8.0-rc0 8433b65] Updating .auroraversion to 0.8.0-rc0.
1 file changed, 1 insertion(+), 1 deletion(-)
Building the source distribution
Signing the distribution
You need a passphrase to unlock the secret key for
user: "Jake Farrell <jf...@apache.org>"
2048-bit DSA key, ID 66B778F9, created 2011-04-13
gpg: gpg-agent is not available in this session
Creating checksums
Done creating the release candidate. The following draft email has been created
to send to the dev@aurora.apache.org mailing list
--------------------------------------------------------------------------------
To: dev@aurora.apache.org
Subject: [VOTE] Release Apache Aurora 0.8.0 RC0
All,
I propose that we accept the following release candidate as the official
Apache Aurora 0.8.0 release.
Aurora 0.8.0-rc0 includes the following:
---
The CHANGELOG for the release is available at:
https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=CHANGELOG&hb=0.8.0-rc0
The branch used to create the release candidate is:
https://git-wip-us.apache.org/repos/asf?p=aurora.git&hb=0.8.0-rc0
The release candidate is available at:
https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz
The MD5 checksum of the release candidate can be found at:
https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.md5
The signature of the release candidate can be found at:
https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.asc
The GPG key used to sign the release are available at:
https://dist.apache.org/repos/dist/dev/aurora/KEYS
Please download, verify, and test.
The vote will close on Mon May 4 23:13:02 EDT 2015
[ ] +1 Release this as Apache Aurora 0.8.0
[ ] +0
[ ] -1 Do not release this as Apache Aurora 0.8.0 because...
--------------------------------------------------------------------------------
This was a dry run, nothing has been published.
To roll back your local repo you will need to run:
git checkout master
git reset --hard fcfd34708dcfed5401696c4afd78637cc5c690f2
git branch -D 0.8.0-rc0
Thanks,
Jake Farrell
Re: Review Request 33773: Aurora-1302: Allow rc script to set an
explicit version
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33773/#review82308
-----------------------------------------------------------
Ship it!
Master (5fc7baf) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 2, 2015, 3:18 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33773/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 3:18 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: Aurora-1302
> https://issues.apache.org/jira/browse/Aurora-1302
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds ability to override current .auroraversion when making an release candidate.
>
> Updating CHANGELOG for 0.8.0 release.
>
>
> Updating .auroraversion to 0.8.0-rc0.
>
>
> Diffs
> -----
>
> build-support/release/release-candidate 14dbeddac663733b23383643dad91db0abe8b9f7
>
> Diff: https://reviews.apache.org/r/33773/diff/
>
>
> Testing
> -------
>
> ./build-support/release/release-candidate -l m -r 0 -v 0.8.0
> Performing dry-run
> Generating changelog
> [master 234be4e] Updating CHANGELOG for 0.8.0 release.
> 1 file changed, 17 insertions(+)
> Creating 0.8.0-rc0 branch
> Committing updated .auroraversion on master
> [master eb6b505] Incrementing snapshot version to 0.9.0-SNAPSHOT.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Checking out 0.8.0-rc0 branch and updating .auroraversion
> Switched to branch '0.8.0-rc0'
> [0.8.0-rc0 8433b65] Updating .auroraversion to 0.8.0-rc0.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Building the source distribution
> Signing the distribution
>
> You need a passphrase to unlock the secret key for
> user: "Jake Farrell <jf...@apache.org>"
> 2048-bit DSA key, ID 66B778F9, created 2011-04-13
>
> gpg: gpg-agent is not available in this session
> Creating checksums
> Done creating the release candidate. The following draft email has been created
> to send to the dev@aurora.apache.org mailing list
>
> --------------------------------------------------------------------------------
>
> To: dev@aurora.apache.org
> Subject: [VOTE] Release Apache Aurora 0.8.0 RC0
>
> All,
>
> I propose that we accept the following release candidate as the official
> Apache Aurora 0.8.0 release.
>
>
> Aurora 0.8.0-rc0 includes the following:
> ---
> The CHANGELOG for the release is available at:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=CHANGELOG&hb=0.8.0-rc0
>
> The branch used to create the release candidate is:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&hb=0.8.0-rc0
>
> The release candidate is available at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz
>
> The MD5 checksum of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.md5
>
> The signature of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.asc
>
> The GPG key used to sign the release are available at:
> https://dist.apache.org/repos/dist/dev/aurora/KEYS
>
> Please download, verify, and test.
>
> The vote will close on Mon May 4 23:13:02 EDT 2015
>
> [ ] +1 Release this as Apache Aurora 0.8.0
> [ ] +0
> [ ] -1 Do not release this as Apache Aurora 0.8.0 because...
>
> --------------------------------------------------------------------------------
>
>
> This was a dry run, nothing has been published.
>
> To roll back your local repo you will need to run:
>
> git checkout master
> git reset --hard fcfd34708dcfed5401696c4afd78637cc5c690f2
> git branch -D 0.8.0-rc0
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33773: Aurora-1302: Allow rc script to set an
explicit version
Posted by Jake Farrell <jf...@apache.org>.
> On May 2, 2015, 5:24 p.m., Bill Farner wrote:
> > Checking my understanding - is the idea that we would bump .auroraversion _after_ the release is complete?
the release candidate script cuts the current rc as .auroraversion minus "-SNAPSHOT" and then sets the .auroraversion in HEAD to current_version plus passed in -l flag (major, minor, patch). so in the current case we have 0.7.1-SNAPSHOT, and are only able to create an rc branch for 0.7.1. This patch allows us to change the current_version during rc avoiding an extra commit, so we can have a point release and then jump to a minor or major as we would like
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33773/#review82320
-----------------------------------------------------------
On May 2, 2015, 3:18 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33773/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 3:18 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: Aurora-1302
> https://issues.apache.org/jira/browse/Aurora-1302
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds ability to override current .auroraversion when making an release candidate.
>
> Updating CHANGELOG for 0.8.0 release.
>
>
> Updating .auroraversion to 0.8.0-rc0.
>
>
> Diffs
> -----
>
> build-support/release/release-candidate 14dbeddac663733b23383643dad91db0abe8b9f7
>
> Diff: https://reviews.apache.org/r/33773/diff/
>
>
> Testing
> -------
>
> ./build-support/release/release-candidate -l m -r 0 -v 0.8.0
> Performing dry-run
> Generating changelog
> [master 234be4e] Updating CHANGELOG for 0.8.0 release.
> 1 file changed, 17 insertions(+)
> Creating 0.8.0-rc0 branch
> Committing updated .auroraversion on master
> [master eb6b505] Incrementing snapshot version to 0.9.0-SNAPSHOT.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Checking out 0.8.0-rc0 branch and updating .auroraversion
> Switched to branch '0.8.0-rc0'
> [0.8.0-rc0 8433b65] Updating .auroraversion to 0.8.0-rc0.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Building the source distribution
> Signing the distribution
>
> You need a passphrase to unlock the secret key for
> user: "Jake Farrell <jf...@apache.org>"
> 2048-bit DSA key, ID 66B778F9, created 2011-04-13
>
> gpg: gpg-agent is not available in this session
> Creating checksums
> Done creating the release candidate. The following draft email has been created
> to send to the dev@aurora.apache.org mailing list
>
> --------------------------------------------------------------------------------
>
> To: dev@aurora.apache.org
> Subject: [VOTE] Release Apache Aurora 0.8.0 RC0
>
> All,
>
> I propose that we accept the following release candidate as the official
> Apache Aurora 0.8.0 release.
>
>
> Aurora 0.8.0-rc0 includes the following:
> ---
> The CHANGELOG for the release is available at:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=CHANGELOG&hb=0.8.0-rc0
>
> The branch used to create the release candidate is:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&hb=0.8.0-rc0
>
> The release candidate is available at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz
>
> The MD5 checksum of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.md5
>
> The signature of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.asc
>
> The GPG key used to sign the release are available at:
> https://dist.apache.org/repos/dist/dev/aurora/KEYS
>
> Please download, verify, and test.
>
> The vote will close on Mon May 4 23:13:02 EDT 2015
>
> [ ] +1 Release this as Apache Aurora 0.8.0
> [ ] +0
> [ ] -1 Do not release this as Apache Aurora 0.8.0 because...
>
> --------------------------------------------------------------------------------
>
>
> This was a dry run, nothing has been published.
>
> To roll back your local repo you will need to run:
>
> git checkout master
> git reset --hard fcfd34708dcfed5401696c4afd78637cc5c690f2
> git branch -D 0.8.0-rc0
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33773: Aurora-1302: Allow rc script to set an
explicit version
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33773/#review82320
-----------------------------------------------------------
Ship it!
Checking my understanding - is the idea that we would bump .auroraversion _after_ the release is complete?
- Bill Farner
On May 2, 2015, 3:18 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33773/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 3:18 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: Aurora-1302
> https://issues.apache.org/jira/browse/Aurora-1302
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds ability to override current .auroraversion when making an release candidate.
>
> Updating CHANGELOG for 0.8.0 release.
>
>
> Updating .auroraversion to 0.8.0-rc0.
>
>
> Diffs
> -----
>
> build-support/release/release-candidate 14dbeddac663733b23383643dad91db0abe8b9f7
>
> Diff: https://reviews.apache.org/r/33773/diff/
>
>
> Testing
> -------
>
> ./build-support/release/release-candidate -l m -r 0 -v 0.8.0
> Performing dry-run
> Generating changelog
> [master 234be4e] Updating CHANGELOG for 0.8.0 release.
> 1 file changed, 17 insertions(+)
> Creating 0.8.0-rc0 branch
> Committing updated .auroraversion on master
> [master eb6b505] Incrementing snapshot version to 0.9.0-SNAPSHOT.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Checking out 0.8.0-rc0 branch and updating .auroraversion
> Switched to branch '0.8.0-rc0'
> [0.8.0-rc0 8433b65] Updating .auroraversion to 0.8.0-rc0.
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Building the source distribution
> Signing the distribution
>
> You need a passphrase to unlock the secret key for
> user: "Jake Farrell <jf...@apache.org>"
> 2048-bit DSA key, ID 66B778F9, created 2011-04-13
>
> gpg: gpg-agent is not available in this session
> Creating checksums
> Done creating the release candidate. The following draft email has been created
> to send to the dev@aurora.apache.org mailing list
>
> --------------------------------------------------------------------------------
>
> To: dev@aurora.apache.org
> Subject: [VOTE] Release Apache Aurora 0.8.0 RC0
>
> All,
>
> I propose that we accept the following release candidate as the official
> Apache Aurora 0.8.0 release.
>
>
> Aurora 0.8.0-rc0 includes the following:
> ---
> The CHANGELOG for the release is available at:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=CHANGELOG&hb=0.8.0-rc0
>
> The branch used to create the release candidate is:
> https://git-wip-us.apache.org/repos/asf?p=aurora.git&hb=0.8.0-rc0
>
> The release candidate is available at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz
>
> The MD5 checksum of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.md5
>
> The signature of the release candidate can be found at:
> https://dist.apache.org/repos/dist/dev/aurora/0.8.0-rc0/apache-aurora-0.8.0-rc0.tar.gz.asc
>
> The GPG key used to sign the release are available at:
> https://dist.apache.org/repos/dist/dev/aurora/KEYS
>
> Please download, verify, and test.
>
> The vote will close on Mon May 4 23:13:02 EDT 2015
>
> [ ] +1 Release this as Apache Aurora 0.8.0
> [ ] +0
> [ ] -1 Do not release this as Apache Aurora 0.8.0 because...
>
> --------------------------------------------------------------------------------
>
>
> This was a dry run, nothing has been published.
>
> To roll back your local repo you will need to run:
>
> git checkout master
> git reset --hard fcfd34708dcfed5401696c4afd78637cc5c690f2
> git branch -D 0.8.0-rc0
>
>
> Thanks,
>
> Jake Farrell
>
>