You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/24 19:49:40 UTC
[GitHub] [hive] viirya opened a new pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
viirya opened a new pull request #1356:
URL: https://github.com/apache/hive/pull/1356
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to shade Guava from hive-exec in Hive 2.3 branch.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.
```
sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.IllegalAccessError: tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.hadoop.hive.ql.exec.FetchOperator
at org.apache.hadoop.hive.ql.exec.FetchOperator.<init>(FetchOperator.java:108)
at org.apache.hadoop.hive.ql.exec.FetchTask.initialize(FetchTask.java:87)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:541)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
```
This is a problem for downstream clients. Hive project noticed that problem too in [HIVE-22126](https://issues.apache.org/jira/browse/HIVE-22126), however that only targets 4.0.0. It'd be nicer if we can also shade Guava from current Hive versions, e.g. Hive 2.3 line.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Guava will be shaded from hive-exec.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Built Hive locally and checked jar content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-668358395
cc @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736804288
Thank you @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736192230
> Yes, my main question is whether it is safe to skip the changes on `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`. It looks fine to me since we've already shaded calcite within hive/ql.
Yeah, it should be fine. Calcite uses guava API so shading guava causes no method error if we don't include calcite in shaded jar of hive/ql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-698556409
Thanks @sunchao for adding jenkins file to branch-2.3. Re-open this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-675751866
@viirya sorry for the delay - I've cherry-picked the change to branch-2.3 as well so you can just close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1356:
URL: https://github.com/apache/hive/pull/1356#discussion_r533044970
##########
File path: itests/hive-blobstore/pom.xml
##########
@@ -55,33 +55,33 @@
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-metastore</artifactId>
+ <artifactId>hive-exec</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-metastore</artifactId>
<version>${project.version}</version>
- <classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-it-unit</artifactId>
+ <artifactId>hive-metastore</artifactId>
Review comment:
Oh cool. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya closed pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #1356:
URL: https://github.com/apache/hive/pull/1356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736796255
Merged to branch-2.3 and branch-2. Thanks @viirya .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-735950137
Internally we test this patch and pass all Spark tests. I think it gives us more confidence to have this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-669633077
@sunchao Do you know how to trigger the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736018282
> Thanks @viirya ! the new PR looks almost good to me except one nit.
>
> Also comparing to the original patch, we don't have changes to `HiveRelDecorrelator`, `HiveAggregate` and `HiveSubQueryRemoveRule`. This is unnecessary because we've shaded Guava within `hive-exec`? (some of the APIs like `operandJ` do not exist in the Calcite version used by branch-2.3 also).
The change to `HiveAggregate` just to remove unused parameter `groupSets` in `deriveRowType`. Not related to shading guava, so I don't apply it.
The change from `operand` to `operandJ` in `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`, cannot apply to branch-2.3 because `operandJ` is not in calcite 1.10.0. The API was add since calcite 1.17.0 (https://github.com/apache/calcite/commit/d59b639d/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1356:
URL: https://github.com/apache/hive/pull/1356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-698556409
Thanks @sunchao for adding jenkins file to branch-2.3. Re-open this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-675752255
Ok, thanks @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-729488760
@sunchao The CI test results look much better now. Seems to me the failed tests are not related to shading guava.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1356:
URL: https://github.com/apache/hive/pull/1356#discussion_r532881891
##########
File path: itests/hive-blobstore/pom.xml
##########
@@ -55,33 +55,33 @@
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-metastore</artifactId>
+ <artifactId>hive-exec</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-metastore</artifactId>
<version>${project.version}</version>
- <classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-it-unit</artifactId>
+ <artifactId>hive-metastore</artifactId>
Review comment:
Oh, I don't change it actually.
This diff looks like I add new `hive-metastore` dependency but in the original pom.xml, it already includes two `hive-metastore`, one is without classifier and one is with `tests` classifier.
Just the way git showing diff confusing readers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1356:
URL: https://github.com/apache/hive/pull/1356#discussion_r465395633
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -207,11 +207,11 @@ public Long getDuration(String method) {
}
- public ImmutableMap<String, Long> getStartTimes() {
+ public Map<String, Long> getStartTimes() {
Review comment:
Without this change, a runtime error like the following was happened:
```
java.lang.NoSuchMethodError: org.apache.hadoop.hive.ql.log.PerfLogger.getStartTimes()Lorg/apache/hive/com/google/common/collect/ImmutableMap;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736771936
Thank you @sunchao. I think this is ready to go, or we need to wait for a couple days?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-729914993
Thanks @viirya . Yes agree they do not look like related. I re-triggered CI just to be sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-675646583
@sunchao Thanks for merging it in branch-2. Does this also need to be merged? Or just close it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1356:
URL: https://github.com/apache/hive/pull/1356#discussion_r532848370
##########
File path: itests/hive-blobstore/pom.xml
##########
@@ -55,33 +55,33 @@
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-metastore</artifactId>
+ <artifactId>hive-exec</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-metastore</artifactId>
<version>${project.version}</version>
- <classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.hive</groupId>
- <artifactId>hive-it-unit</artifactId>
+ <artifactId>hive-metastore</artifactId>
Review comment:
hmm why we need two `hive-metastore` dependencies (one with tests classifier)? I don't see this in the original patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736189137
Yes, my main question is whether it is safe to skip the changes on `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`. It looks fine to me since we've already shaded calcite within hive/ql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org