You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@zookeeper.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2020/02/01 17:20:00 UTC
[jira] [Commented] (ZOOKEEPER-2293) Incorrect log level 'warn' is
resulting in clutering of logs, Suggest to demote it to DEBUG from WARN
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028155#comment-17028155 ]
David Mollitor commented on ZOOKEEPER-2293:
-------------------------------------------
I'm not sure a single global boolean flag is appropriate here. I think it should WARN for each source IP address that this client exists on.
> Incorrect log level 'warn' is resulting in clutering of logs, Suggest to demote it to DEBUG from WARN
> ------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2293
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.6
> Reporter: Praveena Manvi
> Assignee: Rabi Kumar K C
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In https://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> If readOnly flag is not being sent it gets logged as warning. Since we have enabled warning, the server gets filled up with messages like
> Btw, readonly is optional and introduced later (http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode),
> {code}
> 015-08-14T11:03:11+00:00 Connection request from old client /192.168.24.16:14479; will be dropped if server is in r-o mode
> ...
> 2015-08-14T11:21:56+00:00 Connection request from old client
> 2015-08-14T11:18:40+00:00 Connection request from old client /192.168.24.14:12135; will be dropped if server is in r-o mode
> 2015-08-14T11:19:40+00:00 Connection request from old client /192.168.24.14:12310; will be dropped if server is in r-o mode
> {code}
> we are just forced to send read-only flag which is optional to avoid wrong logging level chosen by zookeeper.
> {code}
> boolean readOnly = false;
> try {
> readOnly = bia.readBool("readOnly");
> cnxn.isOldClient = false;
> } catch (IOException e) {
> // this is ok -- just a packet from an old client which
> // doesn't contain readOnly field
> LOG.warn("Connection request from old client "
> + cnxn.getRemoteSocketAddress()
> + "; will be dropped if server is in r-o mode");
> }
> {code}
> Suggest to demote the same to DEBUG as its not intended to warn in anyway.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)