You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/01 15:30:03 UTC

[GitHub] [zookeeper] ctubbsii commented on pull request #1802: ZOOKEEPER-4455: Move to https://reload4j.qos.ch/ (remove log4j1)

ctubbsii commented on pull request #1802:
URL: https://github.com/apache/zookeeper/pull/1802#issuecomment-1026971460


   > @eolivelli looks good to me, but I have thought something else. What about the dependencies used in ZooKeeper.
   > 
   > e.g. ZooKeeper uses jUnit or commons-cli or anything else and they depend on log4j1, shouldn't we exclude log4j1 when we use them?
   
   Yes. In general, ZK should exclude any logging runtimes coming from dependencies using `<exclusions>`, and it should mark any logging runtimes it adds as `<optional>true</optional>`. This would be very helpful for downstream Maven builds that depend on ZK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org