[GitHub] [iotdb] THUMarkLau commented on a diff in pull request #7276: [IOTDB-4251] Persist ChunkMetadata in TsFileIOWriter ahead of time to save memory

[GitBox <gi...@apache.org>]

THUMarkLau commented on code in PR #7276:
URL: https://github.com/apache/iotdb/pull/7276#discussion_r975023899


##########
server/src/main/java/org/apache/iotdb/db/tools/TsFileSplitByPartitionTool.java:
##########
@@ -492,10 +492,10 @@ protected boolean fileCheck() throws IOException {
 
   protected TsFileResource endFileAndGenerateResource(TsFileIOWriter tsFileIOWriter)
       throws IOException {
-    tsFileIOWriter.endFile();
-    TsFileResource tsFileResource = new TsFileResource(tsFileIOWriter.getFile());
     Map<String, List<TimeseriesMetadata>> deviceTimeseriesMetadataMap =
         tsFileIOWriter.getDeviceTimeseriesMetadataMap();

Review Comment:
   This method is used when loading tsfile, all the chunk metadata is in the memory, there is no IO overhead to return all the data at once.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org